[
https://issues.apache.org/jira/browse/GROOVY-11902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18070992#comment-18070992
] ASF GitHub Bot commented on GROOVY-11902: ----------------------------------------- codecov-commenter commented on PR #2433: URL: https://github.com/apache/groovy/pull/2433#issuecomment-4186660761 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2433?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `57.69231%` with `22 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 66.4687%. Comparing base ([`f029ec2`](https://app.codecov.io/gh/apache/groovy/commit/f029ec2b071870ecc54dd599e684c3978f427346?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`004c6bf`](https://app.codecov.io/gh/apache/groovy/commit/004c6bfc0f1c9392c80ce880bab8b2c940cb4bb3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2433?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...rg/apache/groovy/nio/extensions/NioExtensions.java](https://app.codecov.io/gh/apache/groovy/pull/2433?src=pr&el=tree&filepath=subprojects%2Fgroovy-nio%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fnio%2Fextensions%2FNioExtensions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LW5pby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ3Jvb3Z5L25pby9leHRlbnNpb25zL05pb0V4dGVuc2lvbnMuamF2YQ==) | 57.6923% | [21 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2433?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2433?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2433 +/- ## ================================================== - Coverage 66.4692% 66.4687% -0.0005% - Complexity 30035 30043 +8 ================================================== Files 1396 1396 Lines 117119 117171 +52 Branches 20740 20741 +1 ================================================== + Hits 77848 77882 +34 - Misses 32928 32945 +17 - Partials 6343 6344 +1 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2433?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...rg/apache/groovy/nio/extensions/NioExtensions.java](https://app.codecov.io/gh/apache/groovy/pull/2433?src=pr&el=tree&filepath=subprojects%2Fgroovy-nio%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fnio%2Fextensions%2FNioExtensions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LW5pby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ3Jvb3Z5L25pby9leHRlbnNpb25zL05pb0V4dGVuc2lvbnMuamF2YQ==) | `68.3824% <57.6923%> (-1.2806%)` | :arrow_down: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2433/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > minor groovy-nio improvements > ----------------------------- > > Key: GROOVY-11902 > URL: https://issues.apache.org/jira/browse/GROOVY-11902 > Project: Groovy > Issue Type: Improvement > Reporter: Paul King > Assignee: Paul King > Priority: Major > > There are some small async-friendly methods we could add to groovy-nio: > getTextAsync, getTextAsync(charset), getBytesAsync, writeAsync, > writeAsync(charset), writeBytesAsync -- This message was sent by Atlassian Jira (v8.20.10#820010)
