[
https://issues.apache.org/jira/browse/GROOVY-11904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18071097#comment-18071097
] ASF GitHub Bot commented on GROOVY-11904: ----------------------------------------- codecov-commenter commented on PR #2435: URL: https://github.com/apache/groovy/pull/2435#issuecomment-4187469522 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2435?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `90.00000%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 66.4889%. Comparing base ([`fead705`](https://app.codecov.io/gh/apache/groovy/commit/fead705f2c9293f0ac50047fbee4c90c3c6d6cd9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6980577`](https://app.codecov.io/gh/apache/groovy/commit/69805779695689c9bddc23a307609269e045b22f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2435?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...pache/groovy/parser/antlr4/SemanticPredicates.java](https://app.codecov.io/gh/apache/groovy/pull/2435?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fparser%2Fantlr4%2FSemanticPredicates.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9wYXJzZXIvYW50bHI0L1NlbWFudGljUHJlZGljYXRlcy5qYXZh) | 90.0000% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2435?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2435?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2435 +/- ## ================================================== - Coverage 66.4915% 66.4889% -0.0026% - Complexity 30064 30070 +6 ================================================== Files 1396 1396 Lines 117200 117206 +6 Branches 20746 20748 +2 ================================================== + Hits 77928 77929 +1 - Misses 32932 32935 +3 - Partials 6340 6342 +2 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2435?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...pache/groovy/parser/antlr4/SemanticPredicates.java](https://app.codecov.io/gh/apache/groovy/pull/2435?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fparser%2Fantlr4%2FSemanticPredicates.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9wYXJzZXIvYW50bHI0L1NlbWFudGljUHJlZGljYXRlcy5qYXZh) | `83.5165% <90.0000%> (-0.0129%)` | :arrow_down: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2435/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > O(1) Lookup table instead of O(log n) binary search modifiers > ------------------------------------------------------------- > > Key: GROOVY-11904 > URL: https://issues.apache.org/jira/browse/GROOVY-11904 > Project: Groovy > Issue Type: Improvement > Reporter: Daniel Sun > Priority: Major > > Refactored the modifier resolution process to use a pre-computed lookup table > instead of a binary search. This optimization reduces the lookup time > complexity from O(log n) to O(1), enhancing performance during high-frequency > modifier retrievals. -- This message was sent by Atlassian Jira (v8.20.10#820010)
