[
https://issues.apache.org/jira/browse/GROOVY-11900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18071108#comment-18071108
] ASF GitHub Bot commented on GROOVY-11900: ----------------------------------------- codecov-commenter commented on PR #2436: URL: https://github.com/apache/groovy/pull/2436#issuecomment-4187735078 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2436?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `50.00000%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 66.4926%. Comparing base ([`fead705`](https://app.codecov.io/gh/apache/groovy/commit/fead705f2c9293f0ac50047fbee4c90c3c6d6cd9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`eddf0a2`](https://app.codecov.io/gh/apache/groovy/commit/eddf0a2b24a8818d1945f4759783a7cd9ac44af2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2436?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...rg/codehaus/groovy/classgen/AnnotationVisitor.java](https://app.codecov.io/gh/apache/groovy/pull/2436?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fclassgen%2FAnnotationVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NsYXNzZ2VuL0Fubm90YXRpb25WaXNpdG9yLmphdmE=) | 0.0000% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2436?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2436?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2436 +/- ## ================================================== + Coverage 66.4915% 66.4926% +0.0011% - Complexity 30064 30067 +3 ================================================== Files 1396 1396 Lines 117200 117201 +1 Branches 20746 20747 +1 ================================================== + Hits 77928 77930 +2 + Misses 32932 32930 -2 - Partials 6340 6341 +1 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2436?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ava/groovy/grape/GrabAnnotationTransformation.java](https://app.codecov.io/gh/apache/groovy/pull/2436?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fgroovy%2Fgrape%2FGrabAnnotationTransformation.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9ncm9vdnkvZ3JhcGUvR3JhYkFubm90YXRpb25UcmFuc2Zvcm1hdGlvbi5qYXZh) | `47.1850% <100.0000%> (+0.1420%)` | :arrow_up: | | [...rg/codehaus/groovy/classgen/AnnotationVisitor.java](https://app.codecov.io/gh/apache/groovy/pull/2436?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fclassgen%2FAnnotationVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NsYXNzZ2VuL0Fubm90YXRpb25WaXNpdG9yLmphdmE=) | `87.5000% <0.0000%> (ø)` | | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2436/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > grab adds static constructor to annotation definition > ----------------------------------------------------- > > Key: GROOVY-11900 > URL: https://issues.apache.org/jira/browse/GROOVY-11900 > Project: Groovy > Issue Type: Bug > Reporter: Eric Milles > Priority: Major > > Consider the following: > {code:groovy} > @Grab('org.apache.commons:commons-lang3:3.20.0') > import org.apache.commons.lang3.StringUtils > @interface A { String value() } > @A(StringUtils.EMPTY) class C { } > {code} > The last line produces error "No explicit/default value found for annotation > attribute '<clinit>' ". > Not sure if static clinit is supported for annotations. If it is, the > attribute checking needs a filter for it. Maybe the filter should include > all static methods. > WRT grab, should it be adding its magic to all classes of a script class or > just the script class? -- This message was sent by Atlassian Jira (v8.20.10#820010)
