[
https://issues.apache.org/jira/browse/GROOVY-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18071323#comment-18071323
]
ASF GitHub Bot commented on GROOVY-11906:
-----------------------------------------
codecov-commenter commented on PR #2442:
URL: https://github.com/apache/groovy/pull/2442#issuecomment-4189990528
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2442?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 66.5742%. Comparing base
([`116c24a`](https://app.codecov.io/gh/apache/groovy/commit/116c24a29ed28a8f55396388345e898c1b61e273?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
to head
([`6d5d4a5`](https://app.codecov.io/gh/apache/groovy/commit/6d5d4a529c15d94b58adba049d6700696721781f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/groovy/pull/2442?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #2442 +/- ##
==================================================
+ Coverage 66.5717% 66.5742% +0.0025%
- Complexity 30324 30325 +1
==================================================
Files 1404 1405 +1
Lines 117571 117565 -6
Branches 20848 20846 -2
==================================================
- Hits 78269 78268 -1
+ Misses 32905 32900 -5
Partials 6397 6397
```
| [Files with missing
lines](https://app.codecov.io/gh/apache/groovy/pull/2442?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Coverage Δ | |
|---|---|---|
|
[...s/groovy/ast/decompiled/FormalParameterParser.java](https://app.codecov.io/gh/apache/groovy/pull/2442?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fast%2Fdecompiled%2FFormalParameterParser.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2FzdC9kZWNvbXBpbGVkL0Zvcm1hbFBhcmFtZXRlclBhcnNlci5qYXZh)
| `100.0000% <ø> (ø)` | |
|
[...aus/groovy/ast/decompiled/TypeSignatureParser.java](https://app.codecov.io/gh/apache/groovy/pull/2442?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fast%2Fdecompiled%2FTypeSignatureParser.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2FzdC9kZWNvbXBpbGVkL1R5cGVTaWduYXR1cmVQYXJzZXIuamF2YQ==)
| `96.4286% <ø> (ø)` | |
|
[.../org/codehaus/groovy/vmplugin/VMPluginFactory.java](https://app.codecov.io/gh/apache/groovy/pull/2442?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fvmplugin%2FVMPluginFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3ZtcGx1Z2luL1ZNUGx1Z2luRmFjdG9yeS5qYXZh)
| `44.4444% <100.0000%> (-2.9240%)` | :arrow_down: |
|
[.../java/org/codehaus/groovy/vmplugin/v10/Java10.java](https://app.codecov.io/gh/apache/groovy/pull/2442?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fvmplugin%2Fv10%2FJava10.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3ZtcGx1Z2luL3YxMC9KYXZhMTAuamF2YQ==)
| `85.7143% <ø> (ø)` | |
|
[.../java/org/codehaus/groovy/vmplugin/v16/Java16.java](https://app.codecov.io/gh/apache/groovy/pull/2442?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fvmplugin%2Fv16%2FJava16.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3ZtcGx1Z2luL3YxNi9KYXZhMTYuamF2YQ==)
| `52.0000% <ø> (-4.0000%)` | :arrow_down: |
|
[.../java/org/codehaus/groovy/vmplugin/v17/Java17.java](https://app.codecov.io/gh/apache/groovy/pull/2442?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fvmplugin%2Fv17%2FJava17.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3ZtcGx1Z2luL3YxNy9KYXZhMTcuamF2YQ==)
| `100.0000% <100.0000%> (ø)` | |
|
[...in/java/org/codehaus/groovy/vmplugin/v8/Java8.java](https://app.codecov.io/gh/apache/groovy/pull/2442?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fvmplugin%2Fv8%2FJava8.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3ZtcGx1Z2luL3Y4L0phdmE4LmphdmE=)
| `77.8947% <ø> (+0.8400%)` | :arrow_up: |
|
[...java/org/codehaus/groovy/vmplugin/v8/Selector.java](https://app.codecov.io/gh/apache/groovy/pull/2442?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fvmplugin%2Fv8%2FSelector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3ZtcGx1Z2luL3Y4L1NlbGVjdG9yLmphdmE=)
| `81.2371% <ø> (ø)` | |
|
[...in/java/org/codehaus/groovy/vmplugin/v9/Java9.java](https://app.codecov.io/gh/apache/groovy/pull/2442?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fvmplugin%2Fv9%2FJava9.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3ZtcGx1Z2luL3Y5L0phdmE5LmphdmE=)
| `62.6016% <ø> (ø)` | |
... and [3 files with indirect coverage
changes](https://app.codecov.io/gh/apache/groovy/pull/2442/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests,
report on failures, and find test suite problems.
- :package: [JS Bundle
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save
yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
> VMPlugin cleanup for Groovy 6
> -----------------------------
>
> Key: GROOVY-11906
> URL: https://issues.apache.org/jira/browse/GROOVY-11906
> Project: Groovy
> Issue Type: Improvement
> Reporter: Paul King
> Assignee: Paul King
> Priority: Major
>
> Since Groovy 6 has JDK17 minimum, the older JDK versions in the vmplugin
> hierarchy, while not causing any harm, are essentially offering no value by
> being split.
>
> As a first step, I propose the following vmplugin refactoring:
> - Create v17/Java17.java extending Java16
> - Update VMPluginFactory to use only Java17
> - Deprecate Java8, Java9, Java10, Java16 for removal
> - Leave existing auxiliary files in place
> - Added @SuppressWarnings("removal") at call sites using the old classes
> Subsequently, we can choose to remove some of the older files and "push
> functionality up the hierarchy".
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
