[
https://issues.apache.org/jira/browse/GROOVY-11908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18071541#comment-18071541
] ASF GitHub Bot commented on GROOVY-11908: ----------------------------------------- codecov-commenter commented on PR #2444: URL: https://github.com/apache/groovy/pull/2444#issuecomment-4195147112 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2444?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `68.57143%` with `66 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 66.5782%. Comparing base ([`5895ec5`](https://app.codecov.io/gh/apache/groovy/commit/5895ec5040b734be5844c6fde36d5b3ddf997238?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`49a00b9`](https://app.codecov.io/gh/apache/groovy/commit/49a00b92d9e641a09c370ae482221d1c961172c3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2444?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...main/groovy/groovy/typecheckers/NullChecker.groovy](https://app.codecov.io/gh/apache/groovy/pull/2444?src=pr&el=tree&filepath=subprojects%2Fgroovy-typecheckers%2Fsrc%2Fmain%2Fgroovy%2Fgroovy%2Ftypecheckers%2FNullChecker.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LXR5cGVjaGVja2Vycy9zcmMvbWFpbi9ncm9vdnkvZ3Jvb3Z5L3R5cGVjaGVja2Vycy9OdWxsQ2hlY2tlci5ncm9vdnk=) | 71.3450% | [7 Missing and 42 partials :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2444?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...nsform/stc/GroovyTypeCheckingExtensionSupport.java](https://app.codecov.io/gh/apache/groovy/pull/2444?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2Fstc%2FGroovyTypeCheckingExtensionSupport.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9zdGMvR3Jvb3Z5VHlwZUNoZWNraW5nRXh0ZW5zaW9uU3VwcG9ydC5qYXZh) | 57.1429% | [10 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2444?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...us/groovy/transform/stc/TypeCheckingExtension.java](https://app.codecov.io/gh/apache/groovy/pull/2444?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2Fstc%2FTypeCheckingExtension.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9zdGMvVHlwZUNoZWNraW5nRXh0ZW5zaW9uLmphdmE=) | 50.0000% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2444?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2444?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2444 +/- ## ================================================== + Coverage 66.5725% 66.5782% +0.0057% + Complexity 30324 30226 -98 ================================================== Files 1404 1402 -2 Lines 117571 117594 +23 Branches 20848 20859 +11 ================================================== + Hits 78270 78292 +22 Misses 32903 32903 - Partials 6398 6399 +1 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2444?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...us/groovy/transform/stc/TypeCheckingExtension.java](https://app.codecov.io/gh/apache/groovy/pull/2444?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2Fstc%2FTypeCheckingExtension.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9zdGMvVHlwZUNoZWNraW5nRXh0ZW5zaW9uLmphdmE=) | `66.6667% <50.0000%> (-1.0753%)` | :arrow_down: | | [...nsform/stc/GroovyTypeCheckingExtensionSupport.java](https://app.codecov.io/gh/apache/groovy/pull/2444?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2Fstc%2FGroovyTypeCheckingExtensionSupport.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9zdGMvR3Jvb3Z5VHlwZUNoZWNraW5nRXh0ZW5zaW9uU3VwcG9ydC5qYXZh) | `77.1784% <57.1429%> (-3.8642%)` | :arrow_down: | | [...main/groovy/groovy/typecheckers/NullChecker.groovy](https://app.codecov.io/gh/apache/groovy/pull/2444?src=pr&el=tree&filepath=subprojects%2Fgroovy-typecheckers%2Fsrc%2Fmain%2Fgroovy%2Fgroovy%2Ftypecheckers%2FNullChecker.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LXR5cGVjaGVja2Vycy9zcmMvbWFpbi9ncm9vdnkvZ3Jvb3Z5L3R5cGVjaGVja2Vycy9OdWxsQ2hlY2tlci5ncm9vdnk=) | `71.3450% <71.3450%> (-28.6550%)` | :arrow_down: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2444/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > Support parameterized type checking extensions > ---------------------------------------------- > > Key: GROOVY-11908 > URL: https://issues.apache.org/jira/browse/GROOVY-11908 > Project: Groovy > Issue Type: Improvement > Reporter: Paul King > Assignee: Paul King > Priority: Major > > Add support for passing named parameters to type checking extensions via the > extension string, e.g.: > {code:groovy} > @TypeChecked(extensions = 'groovy.typecheckers.NullChecker(strict: true)') > {code} > Parameters are parsed as key-value pairs and made available to extensions via > a getOptions() method on TypeCheckingExtension. This avoids the need for > separate extension classes that differ only in configuration. > As a first use, StrictNullChecker is removed in favour of NullChecker(strict: > true). > Since we haven't released that yet, it seems like a good candidate. -- This message was sent by Atlassian Jira (v8.20.10#820010)
