[
https://issues.apache.org/jira/browse/GROOVY-11911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18071607#comment-18071607
] ASF GitHub Bot commented on GROOVY-11911: ----------------------------------------- codecov-commenter commented on PR #2447: URL: https://github.com/apache/groovy/pull/2447#issuecomment-4196700441 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2447?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `90.32258%` with `3 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 66.4897%. Comparing base ([`799c8cd`](https://app.codecov.io/gh/apache/groovy/commit/799c8cd7866902bd8116d1fb02a8d8790b3df81b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`cebb589`](https://app.codecov.io/gh/apache/groovy/commit/cebb589f8ce5f471c8abcb0aea8e4f2cb525852f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2447?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...untime/callsite/BooleanClosureForMapPredicate.java](https://app.codecov.io/gh/apache/groovy/pull/2447?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2Fcallsite%2FBooleanClosureForMapPredicate.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvY2FsbHNpdGUvQm9vbGVhbkNsb3N1cmVGb3JNYXBQcmVkaWNhdGUuamF2YQ==) | 0.0000% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2447?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../codehaus/groovy/runtime/DefaultGroovyMethods.java](https://app.codecov.io/gh/apache/groovy/pull/2447?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2FDefaultGroovyMethods.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvRGVmYXVsdEdyb292eU1ldGhvZHMuamF2YQ==) | 75.0000% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2447?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2447?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2447 +/- ## ================================================== - Coverage 66.5628% 66.4897% -0.0730% + Complexity 30248 30212 -36 ================================================== Files 1406 1408 +2 Lines 117737 117749 +12 Branches 20907 20907 ================================================== - Hits 78369 78291 -78 - Misses 32934 33031 +97 + Partials 6434 6427 -7 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2447?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [src/main/java/groovy/lang/Closure.java](https://app.codecov.io/gh/apache/groovy/pull/2447?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fgroovy%2Flang%2FClosure.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9ncm9vdnkvbGFuZy9DbG9zdXJlLmphdmE=) | `79.0476% <ø> (ø)` | | | [...rg/codehaus/groovy/runtime/ArrayGroovyMethods.java](https://app.codecov.io/gh/apache/groovy/pull/2447?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2FArrayGroovyMethods.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvQXJyYXlHcm9vdnlNZXRob2RzLmphdmE=) | `89.6573% <100.0000%> (-0.0063%)` | :arrow_down: | | [.../groovy/runtime/BooleanClosureForMapPredicate.java](https://app.codecov.io/gh/apache/groovy/pull/2447?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2FBooleanClosureForMapPredicate.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvQm9vbGVhbkNsb3N1cmVGb3JNYXBQcmVkaWNhdGUuamF2YQ==) | `100.0000% <100.0000%> (ø)` | | | [...dehaus/groovy/runtime/BooleanClosurePredicate.java](https://app.codecov.io/gh/apache/groovy/pull/2447?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2FBooleanClosurePredicate.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvQm9vbGVhbkNsb3N1cmVQcmVkaWNhdGUuamF2YQ==) | `100.0000% <100.0000%> (ø)` | | | [...codehaus/groovy/runtime/BooleanClosureWrapper.java](https://app.codecov.io/gh/apache/groovy/pull/2447?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2FBooleanClosureWrapper.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvQm9vbGVhbkNsb3N1cmVXcmFwcGVyLmphdmE=) | `100.0000% <100.0000%> (ø)` | | | [...a/org/codehaus/groovy/runtime/IOGroovyMethods.java](https://app.codecov.io/gh/apache/groovy/pull/2447?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2FIOGroovyMethods.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvSU9Hcm9vdnlNZXRob2RzLmphdmE=) | `90.0000% <ø> (ø)` | | | [...codehaus/groovy/runtime/ResourceGroovyMethods.java](https://app.codecov.io/gh/apache/groovy/pull/2447?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2FResourceGroovyMethods.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvUmVzb3VyY2VHcm9vdnlNZXRob2RzLmphdmE=) | `83.3698% <100.0000%> (-0.0363%)` | :arrow_down: | | [...oovy/runtime/callsite/BooleanClosurePredicate.java](https://app.codecov.io/gh/apache/groovy/pull/2447?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2Fcallsite%2FBooleanClosurePredicate.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvY2FsbHNpdGUvQm9vbGVhbkNsb3N1cmVQcmVkaWNhdGUuamF2YQ==) | `0.0000% <ø> (-100.0000%)` | :arrow_down: | | [...groovy/runtime/callsite/BooleanClosureWrapper.java](https://app.codecov.io/gh/apache/groovy/pull/2447?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2Fcallsite%2FBooleanClosureWrapper.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvY2FsbHNpdGUvQm9vbGVhbkNsb3N1cmVXcmFwcGVyLmphdmE=) | `0.0000% <ø> (-100.0000%)` | :arrow_down: | | [...untime/callsite/BooleanReturningMethodInvoker.java](https://app.codecov.io/gh/apache/groovy/pull/2447?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2Fcallsite%2FBooleanReturningMethodInvoker.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvY2FsbHNpdGUvQm9vbGVhblJldHVybmluZ01ldGhvZEludm9rZXIuamF2YQ==) | `0.0000% <ø> (-72.2222%)` | :arrow_down: | | ... and [3 more](https://app.codecov.io/gh/apache/groovy/pull/2447?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | ... and [10 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2447/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > Deprecate callsite versions of BooleanClosureWrapper > ---------------------------------------------------- > > Key: GROOVY-11911 > URL: https://issues.apache.org/jira/browse/GROOVY-11911 > Project: Groovy > Issue Type: Task > Reporter: Paul King > Assignee: Paul King > Priority: Major > > We started a long time ago removing callsite code moving it to indy. See also > GROOVY-11158. We paused for resource reasons but also we found callsite code > is still faster in numerous situations. This issue is just to relook at the > parts of GROOVY-11158 related to BooleanClosureWrapper. -- This message was sent by Atlassian Jira (v8.20.10#820010)
