[
https://issues.apache.org/jira/browse/GROOVY-11915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18072783#comment-18072783
] ASF GitHub Bot commented on GROOVY-11915: ----------------------------------------- codecov-commenter commented on PR #2457: URL: https://github.com/apache/groovy/pull/2457#issuecomment-4228166531 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2457?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `50.00000%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 66.4901%. Comparing base ([`e0d51fd`](https://app.codecov.io/gh/apache/groovy/commit/e0d51fde6869d6121231f7943d22ad3254072944?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`322b6e6`](https://app.codecov.io/gh/apache/groovy/commit/322b6e6cc64a1853eaa34953ea9dd9dc73bbb19a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2457?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...q/provider/collection/runtime/GroupResultImpl.java](https://app.codecov.io/gh/apache/groovy/pull/2457?src=pr&el=tree&filepath=subprojects%2Fgroovy-ginq%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fapache%2Fgroovy%2Fginq%2Fprovider%2Fcollection%2Fruntime%2FGroupResultImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWdpbnEvc3JjL21haW4vZ3Jvb3Z5L29yZy9hcGFjaGUvZ3Jvb3Z5L2dpbnEvcHJvdmlkZXIvY29sbGVjdGlvbi9ydW50aW1lL0dyb3VwUmVzdWx0SW1wbC5qYXZh) | 50.0000% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2457?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2457?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2457 +/- ## ================================================== - Coverage 66.4918% 66.4901% -0.0017% Complexity 30268 30268 ================================================== Files 1411 1411 Lines 118016 118016 Branches 20987 20987 ================================================== - Hits 78471 78469 -2 + Misses 33072 33071 -1 - Partials 6473 6476 +3 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2457?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...q/provider/collection/runtime/GroupResultImpl.java](https://app.codecov.io/gh/apache/groovy/pull/2457?src=pr&el=tree&filepath=subprojects%2Fgroovy-ginq%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fapache%2Fgroovy%2Fginq%2Fprovider%2Fcollection%2Fruntime%2FGroupResultImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWdpbnEvc3JjL21haW4vZ3Jvb3Z5L29yZy9hcGFjaGUvZ3Jvb3Z5L2dpbnEvcHJvdmlkZXIvY29sbGVjdGlvbi9ydW50aW1lL0dyb3VwUmVzdWx0SW1wbC5qYXZh) | `66.6667% <50.0000%> (ø)` | | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2457/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > GINQ: Add groupby...into with first-class GroupResult type > ---------------------------------------------------------- > > Key: GROOVY-11915 > URL: https://issues.apache.org/jira/browse/GROOVY-11915 > Project: Groovy > Issue Type: Improvement > Reporter: Paul King > Assignee: Paul King > Priority: Major > > For GINQ, introduce an optional "into <alias>" clause for groupby that binds > a GroupResult<K, T> variable (extending Queryable<T> with a key property). > When used, this would replace the current magic aggregate function rewriting > with real method calls on a first-class type, enabling composable group > queries (e.g. {{g.where(...).toList()}}), simplifying the correctVars logic > in GinqAstWalker, and making the backend Queryable API directly usable for > grouped queries. > The existing groupby syntax (without "into") would continue to work unchanged. > If we ever provided a GINQ SQL provider, GroupResult maps cleanly to SQL > GROUP BY + aggregate functions. -- This message was sent by Atlassian Jira (v8.20.10#820010)
