[
https://issues.apache.org/jira/browse/GROOVY-11928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18073129#comment-18073129
]
ASF GitHub Bot commented on GROOVY-11928:
-----------------------------------------
codecov-commenter commented on PR #2467:
URL: https://github.com/apache/groovy/pull/2467#issuecomment-4235703904
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
:x: Patch coverage is `72.05882%` with `19 lines` in your changes missing
coverage. Please review.
:white_check_mark: Project coverage is 66.5023%. Comparing base
([`165bfd1`](https://app.codecov.io/gh/apache/groovy/commit/165bfd12f1b2c25250378fe90413d268a692c32b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
to head
([`b938caa`](https://app.codecov.io/gh/apache/groovy/commit/b938caa030a24b45df8845ecfedd557363c66db3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing
lines](https://app.codecov.io/gh/apache/groovy/pull/2467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Patch % | Lines |
|---|---|---|
|
[...us/groovy/transform/AbstractASTTransformation.java](https://app.codecov.io/gh/apache/groovy/pull/2467?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2FAbstractASTTransformation.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9BYnN0cmFjdEFTVFRyYW5zZm9ybWF0aW9uLmphdmE=)
| 73.3333% | [1 Missing and 3 partials :warning:
](https://app.codecov.io/gh/apache/groovy/pull/2467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
|
[.../transform/EqualsAndHashCodeASTTransformation.java](https://app.codecov.io/gh/apache/groovy/pull/2467?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2FEqualsAndHashCodeASTTransformation.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9FcXVhbHNBbmRIYXNoQ29kZUFTVFRyYW5zZm9ybWF0aW9uLmphdmE=)
| 42.8571% | [1 Missing and 3 partials :warning:
](https://app.codecov.io/gh/apache/groovy/pull/2467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
|
[src/main/java/groovy/lang/MetaClassImpl.java](https://app.codecov.io/gh/apache/groovy/pull/2467?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fgroovy%2Flang%2FMetaClassImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9ncm9vdnkvbGFuZy9NZXRhQ2xhc3NJbXBsLmphdmE=)
| 80.0000% | [1 Missing and 2 partials :warning:
](https://app.codecov.io/gh/apache/groovy/pull/2467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
|
[...rg/apache/groovy/ast/tools/AnnotatedNodeUtils.java](https://app.codecov.io/gh/apache/groovy/pull/2467?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fast%2Ftools%2FAnnotatedNodeUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9hc3QvdG9vbHMvQW5ub3RhdGVkTm9kZVV0aWxzLmphdmE=)
| 78.5714% | [1 Missing and 2 partials :warning:
](https://app.codecov.io/gh/apache/groovy/pull/2467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
|
[...us/groovy/transform/DelegateASTTransformation.java](https://app.codecov.io/gh/apache/groovy/pull/2467?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2FDelegateASTTransformation.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9EZWxlZ2F0ZUFTVFRyYW5zZm9ybWF0aW9uLmphdmE=)
| 66.6667% | [0 Missing and 2 partials :warning:
](https://app.codecov.io/gh/apache/groovy/pull/2467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
|
[...aus/groovy/transform/BuilderASTTransformation.java](https://app.codecov.io/gh/apache/groovy/pull/2467?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2FBuilderASTTransformation.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9CdWlsZGVyQVNUVHJhbnNmb3JtYXRpb24uamF2YQ==)
| 66.6667% | [1 Missing :warning:
](https://app.codecov.io/gh/apache/groovy/pull/2467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
|
[...s/groovy/transform/ImmutableASTTransformation.java](https://app.codecov.io/gh/apache/groovy/pull/2467?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2FImmutableASTTransformation.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9JbW11dGFibGVBU1RUcmFuc2Zvcm1hdGlvbi5qYXZh)
| 0.0000% | [0 Missing and 1 partial :warning:
](https://app.codecov.io/gh/apache/groovy/pull/2467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
|
[...y/transform/TupleConstructorASTTransformation.java](https://app.codecov.io/gh/apache/groovy/pull/2467?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2FTupleConstructorASTTransformation.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9UdXBsZUNvbnN0cnVjdG9yQVNUVHJhbnNmb3JtYXRpb24uamF2YQ==)
| 50.0000% | [0 Missing and 1 partial :warning:
](https://app.codecov.io/gh/apache/groovy/pull/2467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/groovy/pull/2467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #2467 +/- ##
==================================================
+ Coverage 66.5002% 66.5023% +0.0020%
- Complexity 30418 30439 +21
==================================================
Files 1420 1420
Lines 118577 118623 +46
Branches 21044 21061 +17
==================================================
+ Hits 78854 78887 +33
- Misses 33204 33211 +7
- Partials 6519 6525 +6
```
| [Files with missing
lines](https://app.codecov.io/gh/apache/groovy/pull/2467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Coverage Δ | |
|---|---|---|
|
[...dehaus/groovy/transform/LazyASTTransformation.java](https://app.codecov.io/gh/apache/groovy/pull/2467?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2FLazyASTTransformation.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9MYXp5QVNUVHJhbnNmb3JtYXRpb24uamF2YQ==)
| `95.3125% <100.0000%> (+0.0369%)` | :arrow_up: |
|
[...ovy/transform/MapConstructorASTTransformation.java](https://app.codecov.io/gh/apache/groovy/pull/2467?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2FMapConstructorASTTransformation.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9NYXBDb25zdHJ1Y3RvckFTVFRyYW5zZm9ybWF0aW9uLmphdmE=)
| `81.8182% <100.0000%> (ø)` | |
|
[...oovy/transform/ReadWriteLockASTTransformation.java](https://app.codecov.io/gh/apache/groovy/pull/2467?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2FReadWriteLockASTTransformation.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9SZWFkV3JpdGVMb2NrQVNUVHJhbnNmb3JtYXRpb24uamF2YQ==)
| `80.3571% <100.0000%> (+0.7275%)` | :arrow_up: |
|
[...us/groovy/transform/ToStringASTTransformation.java](https://app.codecov.io/gh/apache/groovy/pull/2467?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2FToStringASTTransformation.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9Ub1N0cmluZ0FTVFRyYW5zZm9ybWF0aW9uLmphdmE=)
| `84.5070% <100.0000%> (ø)` | |
|
[...aus/groovy/transform/BuilderASTTransformation.java](https://app.codecov.io/gh/apache/groovy/pull/2467?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2FBuilderASTTransformation.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9CdWlsZGVyQVNUVHJhbnNmb3JtYXRpb24uamF2YQ==)
| `62.5899% <66.6667%> (ø)` | |
|
[...s/groovy/transform/ImmutableASTTransformation.java](https://app.codecov.io/gh/apache/groovy/pull/2467?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2FImmutableASTTransformation.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9JbW11dGFibGVBU1RUcmFuc2Zvcm1hdGlvbi5qYXZh)
| `66.8367% <0.0000%> (ø)` | |
|
[...y/transform/TupleConstructorASTTransformation.java](https://app.codecov.io/gh/apache/groovy/pull/2467?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2FTupleConstructorASTTransformation.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9UdXBsZUNvbnN0cnVjdG9yQVNUVHJhbnNmb3JtYXRpb24uamF2YQ==)
| `84.1346% <50.0000%> (ø)` | |
|
[...us/groovy/transform/DelegateASTTransformation.java](https://app.codecov.io/gh/apache/groovy/pull/2467?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2FDelegateASTTransformation.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9EZWxlZ2F0ZUFTVFRyYW5zZm9ybWF0aW9uLmphdmE=)
| `87.4477% <66.6667%> (+0.0527%)` | :arrow_up: |
|
[src/main/java/groovy/lang/MetaClassImpl.java](https://app.codecov.io/gh/apache/groovy/pull/2467?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fgroovy%2Flang%2FMetaClassImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9ncm9vdnkvbGFuZy9NZXRhQ2xhc3NJbXBsLmphdmE=)
| `77.0039% <80.0000%> (+0.0423%)` | :arrow_up: |
|
[...rg/apache/groovy/ast/tools/AnnotatedNodeUtils.java](https://app.codecov.io/gh/apache/groovy/pull/2467?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fast%2Ftools%2FAnnotatedNodeUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9hc3QvdG9vbHMvQW5ub3RhdGVkTm9kZVV0aWxzLmphdmE=)
| `78.2609% <78.5714%> (+0.4831%)` | :arrow_up: |
| ... and [2
more](https://app.codecov.io/gh/apache/groovy/pull/2467?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| |
... and [3 files with indirect coverage
changes](https://app.codecov.io/gh/apache/groovy/pull/2467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests,
report on failures, and find test suite problems.
- :package: [JS Bundle
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save
yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
> Make MetaClassImpl.getProperties() respect @Internal
> ----------------------------------------------------
>
> Key: GROOVY-11928
> URL: https://issues.apache.org/jira/browse/GROOVY-11928
> Project: Groovy
> Issue Type: Improvement
> Reporter: Paul King
> Assignee: Paul King
> Priority: Major
>
> MetaClassImpl.getProperties() does not check for @Internal annotations on
> fields or getter/setter methods. This creates an inconsistency:
> * At compile time, BeanUtils.getAllProperties() already skips methods
> annotated with @Internal (since GROOVY-9081).
> * At runtime, MetaClassImpl.getProperties() does not check @Internal, so
> tools like JsonOutput.toJson(), println, and other
> property-introspection-based features expose internal properties.
> AST transforms that generate internal fields (often with $ in the name)
> currently rely on ad-hoc excludes logic or deemedInternalName() checks in
> each individual transform (@ToString, @EqualsAndHashCode, @Delegate, etc.).
> If getProperties() respected @Internal, these transforms could simply
> annotate generated fields/accessors with @Internal and the filtering would
> happen consistently everywhere — both at compile time and runtime.
> This supercedes GROOVY-11516 which looked for a simplistic solution for names
> containing "$" but never really solved all the cases.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
