paulk-asert commented on PR #2429: URL: https://github.com/apache/groovy/pull/2429#issuecomment-4259575345
@jonnybot0 I initially thought just to bring in half of your first branch - let duplicate imports from modules be treated the same as duplicates from star imports. And in fact changed (locally) the PR branch to have that. But the order from the module imports isn't deterministic from the JDK APIs, so in fact what you have in the first branch is exactly what we need as the smallest bump from what I had. We have GROOVY-11916 for the package-private anomaly. I wonder whether we should take this opportunity (via another issue) to give an error for the multiple static import ambiguity case too. It would be breaking but I imagine easy for folks to understand. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
