[
https://issues.apache.org/jira/browse/GROOVY-5436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18074600#comment-18074600
] ASF GitHub Bot commented on GROOVY-5436: ---------------------------------------- codecov-commenter commented on PR #2474: URL: https://github.com/apache/groovy/pull/2474#issuecomment-4274758082 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2474?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `75.00000%` with `25 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.1562%. Comparing base ([`4a57272`](https://app.codecov.io/gh/apache/groovy/commit/4a57272e43772bc4991712df921a49ff8eb0de36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d40a1b4`](https://app.codecov.io/gh/apache/groovy/commit/d40a1b4854e5261ed816e51a296b5d157fa8b603?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2474?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...y-sql/src/main/java/groovy/sql/InListExpander.java](https://app.codecov.io/gh/apache/groovy/pull/2474?src=pr&el=tree&filepath=subprojects%2Fgroovy-sql%2Fsrc%2Fmain%2Fjava%2Fgroovy%2Fsql%2FInListExpander.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LXNxbC9zcmMvbWFpbi9qYXZhL2dyb292eS9zcWwvSW5MaXN0RXhwYW5kZXIuamF2YQ==) | 72.2222% | [14 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2474?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2474?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2474 +/- ## ================================================== + Coverage 67.1472% 67.1562% +0.0090% - Complexity 30944 30964 +20 ================================================== Files 1438 1439 +1 Lines 120148 120245 +97 Branches 21311 21328 +17 ================================================== + Hits 80676 80752 +76 - Misses 32724 32734 +10 - Partials 6748 6759 +11 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2474?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...jects/groovy-sql/src/main/java/groovy/sql/Sql.java](https://app.codecov.io/gh/apache/groovy/pull/2474?src=pr&el=tree&filepath=subprojects%2Fgroovy-sql%2Fsrc%2Fmain%2Fjava%2Fgroovy%2Fsql%2FSql.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LXNxbC9zcmMvbWFpbi9qYXZhL2dyb292eS9zcWwvU3FsLmphdmE=) | `65.7754% <100.0000%> (+0.2149%)` | :arrow_up: | | [...y-sql/src/main/java/groovy/sql/InListExpander.java](https://app.codecov.io/gh/apache/groovy/pull/2474?src=pr&el=tree&filepath=subprojects%2Fgroovy-sql%2Fsrc%2Fmain%2Fjava%2Fgroovy%2Fsql%2FInListExpander.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LXNxbC9zcmMvbWFpbi9qYXZhL2dyb292eS9zcWwvSW5MaXN0RXhwYW5kZXIuamF2YQ==) | `72.2222% <72.2222%> (ø)` | | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2474/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > add Sql.inList for collection expansion in SQL IN clauses > --------------------------------------------------------- > > Key: GROOVY-5436 > URL: https://issues.apache.org/jira/browse/GROOVY-5436 > Project: Groovy > Issue Type: Improvement > Components: SQL processing > Affects Versions: 1.8.6 > Reporter: Gerhard Stuhlpfarrer > Priority: Major > > Groovy SQL (groovy.sql.Sql) provides methods to bind an Array of parameters > to sql (e.g. rows, eachRow, execute, executeUpdate, ...). > But you have a problem if you need to pass parameter lists to your sql > statement which has a IN clause. > There exists a workaround for this problem, but this is not very groovy. > see discussions here: > http://groovy.329449.n5.nabble.com/In-operator-in-Groovy-SQL-td4768856.html > http://stackoverflow.com/questions/2861230/what-is-the-best-approach-using-jdbc-for-parameterizing-an-in-clause -- This message was sent by Atlassian Jira (v8.20.10#820010)
