[
https://issues.apache.org/jira/browse/GROOVY-11936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18074607#comment-18074607
]
ASF GitHub Bot commented on GROOVY-11936:
-----------------------------------------
codecov-commenter commented on PR #2475:
URL: https://github.com/apache/groovy/pull/2475#issuecomment-4274845026
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2475?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
:x: Patch coverage is `86.66667%` with `2 lines` in your changes missing
coverage. Please review.
:white_check_mark: Project coverage is 67.1568%. Comparing base
([`4a57272`](https://app.codecov.io/gh/apache/groovy/commit/4a57272e43772bc4991712df921a49ff8eb0de36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
to head
([`b0cd0e4`](https://app.codecov.io/gh/apache/groovy/commit/b0cd0e41b670f4858614f43d96e370c4483749f3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing
lines](https://app.codecov.io/gh/apache/groovy/pull/2475?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Patch % | Lines |
|---|---|---|
|
[...jects/groovy-sql/src/main/java/groovy/sql/Sql.java](https://app.codecov.io/gh/apache/groovy/pull/2475?src=pr&el=tree&filepath=subprojects%2Fgroovy-sql%2Fsrc%2Fmain%2Fjava%2Fgroovy%2Fsql%2FSql.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LXNxbC9zcmMvbWFpbi9qYXZhL2dyb292eS9zcWwvU3FsLmphdmE=)
| 86.6667% | [2 Missing :warning:
](https://app.codecov.io/gh/apache/groovy/pull/2475?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/groovy/pull/2475?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #2475 +/- ##
==================================================
+ Coverage 67.1472% 67.1568% +0.0097%
- Complexity 30944 30951 +7
==================================================
Files 1438 1438
Lines 120148 120162 +14
Branches 21311 21311
==================================================
+ Hits 80676 80697 +21
+ Misses 32724 32721 -3
+ Partials 6748 6744 -4
```
| [Files with missing
lines](https://app.codecov.io/gh/apache/groovy/pull/2475?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Coverage Δ | |
|---|---|---|
|
[...jects/groovy-sql/src/main/java/groovy/sql/Sql.java](https://app.codecov.io/gh/apache/groovy/pull/2475?src=pr&el=tree&filepath=subprojects%2Fgroovy-sql%2Fsrc%2Fmain%2Fjava%2Fgroovy%2Fsql%2FSql.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LXNxbC9zcmMvbWFpbi9qYXZhL2dyb292eS9zcWwvU3FsLmphdmE=)
| `65.8104% <86.6667%> (+0.2499%)` | :arrow_up: |
... and [5 files with indirect coverage
changes](https://app.codecov.io/gh/apache/groovy/pull/2475/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests,
report on failures, and find test suite problems.
- :package: [JS Bundle
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save
yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
> Add Map-based named-parameter overloads for call/callWithRows/callWithAllRows
> -----------------------------------------------------------------------------
>
> Key: GROOVY-11936
> URL: https://issues.apache.org/jira/browse/GROOVY-11936
> Project: Groovy
> Issue Type: Improvement
> Reporter: Paul King
> Priority: Major
>
> This is to capture a hidden feature proposal from [~oniseijin] buried in
> comments in GROOVY-7768.
> Basically:
> {code:groovy}
> sql.callWithAllRows '{call sp_who(:id)}', [id: 'myid'], { /* no out params */
> }
> {code}
> Instead of:
> {code:groovy}
> sql.callWithAllRows '{call sp_who(?)}', ['myid'], { ... }
> {code}
> Or another contrived example:
> {code:groovy}
> def rows = sql.callWithRows '{call FindAllByFirstWithTotal(:first, :total)}',
> [first: 'J', total: Sql.VARCHAR], { total ->
> assert total == 'Found total 2'
> }
> assert rows.size() == 2
> {code}
> Or this:
> {code:groovy}
> def rowList = sql.callWithAllRows
> '{call FindAllByFirstAndFindAllByLastWithTotals(:first, :last, :firstOut,
> :lastOut)}',
> [first: 'J', last: 'V', firstOut: Sql.VARCHAR, lastOut: Sql.VARCHAR],
> { firstTotal, lastTotal ->
> assert firstTotal == 'Found total 2'
> assert lastTotal == 'Found total 1'
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
