jamesfredley commented on code in PR #2494: URL: https://github.com/apache/groovy/pull/2494#discussion_r3143921662
########## .github/workflows/groovy-jmh-classic.yml: ########## @@ -0,0 +1,62 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +name: jmh-classic + +on: [push, pull_request] + +permissions: + contents: read + +jobs: + test: + if: >- + contains(github.event.head_commit.message || '', 'GROOVY-') || + contains(github.event.pull_request.title || '', 'GROOVY-') + strategy: + fail-fast: false + matrix: + include: + - suite: bench + pattern: '\\.bench\\.' + - suite: core + pattern: '\\.perf\\.[A-Z]' + - suite: grails + pattern: '\\.perf\\.grails\\.' + runs-on: ubuntu-latest + env: + DEVELOCITY_ACCESS_KEY: ${{ secrets.DEVELOCITY_ACCESS_KEY }} + steps: + - uses: actions/checkout@v6 + - uses: actions/setup-java@v5 + with: + distribution: 'zulu' + java-version: 21 + check-latest: true + - uses: gradle/actions/setup-gradle@0723195856401067f7a2779048b490ace7a47d7c # v5.0.2 + - name: JMH (${{ matrix.suite }} classic) + run: ./gradlew perf:jmh -PbenchInclude=${{ matrix.pattern }} -Pindy=false + timeout-minutes: 60 + - name: Rename JMH result file + run: | + mv subprojects/performance/build/results/jmh/results.txt \ + subprojects/performance/build/results/jmh/results-${{ matrix.suite }}.txt + + - name: Upload reports-jmh-classic-${{ matrix.suite }} + uses: actions/upload-artifact@v7 Review Comment: Done in b5031358 - aligned with `actions/upload-artifact@v4` to match the rest of the GROOVY_5_0_X workflows. Thanks! ########## .github/workflows/groovy-jmh.yml: ########## @@ -0,0 +1,62 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +name: jmh + +on: [push, pull_request] + +permissions: + contents: read + +jobs: + test: + if: >- + contains(github.event.head_commit.message || '', 'GROOVY-') || + contains(github.event.pull_request.title || '', 'GROOVY-') + strategy: + fail-fast: false + matrix: + include: + - suite: bench + pattern: '\\.bench\\.' + - suite: core + pattern: '\\.perf\\.[A-Z]' + - suite: grails + pattern: '\\.perf\\.grails\\.' + runs-on: ubuntu-latest + env: + DEVELOCITY_ACCESS_KEY: ${{ secrets.DEVELOCITY_ACCESS_KEY }} + steps: + - uses: actions/checkout@v6 + - uses: actions/setup-java@v5 + with: + distribution: 'zulu' + java-version: 21 + check-latest: true + - uses: gradle/actions/setup-gradle@0723195856401067f7a2779048b490ace7a47d7c # v5.0.2 + - name: JMH (${{ matrix.suite }}) + run: ./gradlew perf:jmh -PbenchInclude=${{ matrix.pattern }} + timeout-minutes: 60 + - name: Rename JMH result file + run: | + mv subprojects/performance/build/results/jmh/results.txt \ + subprojects/performance/build/results/jmh/results-${{ matrix.suite }}.txt + + - name: Upload reports-jmh-${{ matrix.suite }} + uses: actions/upload-artifact@v7 Review Comment: Done in b5031358 - aligned with `actions/upload-artifact@v4` to match the rest of the GROOVY_5_0_X workflows. Thanks! ########## subprojects/performance/src/jmh/groovy/org/apache/groovy/perf/OperatorBench.groovy: ########## @@ -0,0 +1,207 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.groovy.perf + +import org.openjdk.jmh.annotations.* +import org.openjdk.jmh.infra.Blackhole + +import java.util.concurrent.TimeUnit + +/** + * Tests the performance of Groovy operator overloading. In Groovy every + * operator (+, -, *, /, [], <<, ==, <=>) compiles to a method call + * (plus, minus, multiply, div, getAt, leftShift, equals, compareTo) + * dispatched through invokedynamic. + */ +@Warmup(iterations = 3, time = 2, timeUnit = TimeUnit.SECONDS) +@Measurement(iterations = 5, time = 2, timeUnit = TimeUnit.SECONDS) +@Fork(2) +@BenchmarkMode(Mode.AverageTime) +@OutputTimeUnit(TimeUnit.MILLISECONDS) +@State(Scope.Thread) +class OperatorBench { + static final int ITERATIONS = 1_000_000 + + /** + * Integer addition — dispatches to Integer.plus(Integer). + */ + @Benchmark + void integerPlus(Blackhole bh) { + int sum = 0 + for (int i = 0; i < ITERATIONS; i++) { + sum = sum + i + } + bh.consume(sum) + } + + /** + * Integer multiplication — dispatches to Integer.multiply(Integer). + * Uses modulo to keep operands small and avoid overflow to zero. + */ + @Benchmark + void integerMultiply(Blackhole bh) { + int product = 1 + for (int i = 1; i < ITERATIONS; i++) { + product = (i % 100) * (i % 50) + } + bh.consume(product) Review Comment: Good catch - fixed in b5031358. Updated the comment to accurately describe what the loop does (assignment of bounded operands, not an accumulating product). The benchmark behavior is unchanged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
