[
https://issues.apache.org/jira/browse/GROOVY-11988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18078221#comment-18078221
] ASF GitHub Bot commented on GROOVY-11988: ----------------------------------------- codecov-commenter commented on PR #2512: URL: https://github.com/apache/groovy/pull/2512#issuecomment-4371958494 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2512?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `58.48101%` with `164 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.3116%. Comparing base ([`36870fa`](https://app.codecov.io/gh/apache/groovy/commit/36870fa03c9f07d629ba7b4ebcc279d60cfc65cd?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4d79bf4`](https://app.codecov.io/gh/apache/groovy/commit/4d79bf490c85b31f7985bd13c61314a2bc556ae7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2512?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...groovy/tools/groovydoc/ExternalJavadocSupport.java](https://app.codecov.io/gh/apache/groovy/pull/2512?src=pr&el=tree&filepath=subprojects%2Fgroovy-groovydoc%2Fsrc%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftools%2Fgroovydoc%2FExternalJavadocSupport.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWdyb292eWRvYy9zcmMvbWFpbi9qYXZhL29yZy9jb2RlaGF1cy9ncm9vdnkvdG9vbHMvZ3Jvb3Z5ZG9jL0V4dGVybmFsSmF2YWRvY1N1cHBvcnQuamF2YQ==) | 65.6827% | [52 Missing and 41 partials :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2512?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...g/codehaus/groovy/tools/groovydoc/TagRenderer.java](https://app.codecov.io/gh/apache/groovy/pull/2512?src=pr&el=tree&filepath=subprojects%2Fgroovy-groovydoc%2Fsrc%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftools%2Fgroovydoc%2FTagRenderer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWdyb292eWRvYy9zcmMvbWFpbi9qYXZhL29yZy9jb2RlaGF1cy9ncm9vdnkvdG9vbHMvZ3Jvb3Z5ZG9jL1RhZ1JlbmRlcmVyLmphdmE=) | 38.3333% | [17 Missing and 20 partials :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2512?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...groovy/tools/groovydoc/ExternalGroovyClassDoc.java](https://app.codecov.io/gh/apache/groovy/pull/2512?src=pr&el=tree&filepath=subprojects%2Fgroovy-groovydoc%2Fsrc%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftools%2Fgroovydoc%2FExternalGroovyClassDoc.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWdyb292eWRvYy9zcmMvbWFpbi9qYXZhL29yZy9jb2RlaGF1cy9ncm9vdnkvdG9vbHMvZ3Jvb3Z5ZG9jL0V4dGVybmFsR3Jvb3Z5Q2xhc3NEb2MuamF2YQ==) | 39.3939% | [18 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2512?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...s/groovy/tools/groovydoc/SimpleGroovyClassDoc.java](https://app.codecov.io/gh/apache/groovy/pull/2512?src=pr&el=tree&filepath=subprojects%2Fgroovy-groovydoc%2Fsrc%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftools%2Fgroovydoc%2FSimpleGroovyClassDoc.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWdyb292eWRvYy9zcmMvbWFpbi9qYXZhL29yZy9jb2RlaGF1cy9ncm9vdnkvdG9vbHMvZ3Jvb3Z5ZG9jL1NpbXBsZUdyb292eUNsYXNzRG9jLmphdmE=) | 45.4546% | [9 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2512?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...codehaus/groovy/tools/groovydoc/GroovyDocTool.java](https://app.codecov.io/gh/apache/groovy/pull/2512?src=pr&el=tree&filepath=subprojects%2Fgroovy-groovydoc%2Fsrc%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftools%2Fgroovydoc%2FGroovyDocTool.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWdyb292eWRvYy9zcmMvbWFpbi9qYXZhL29yZy9jb2RlaGF1cy9ncm9vdnkvdG9vbHMvZ3Jvb3Z5ZG9jL0dyb292eURvY1Rvb2wuamF2YQ==) | 77.7778% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2512?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2512?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2512 +/- ## ================================================== - Coverage 67.3329% 67.3116% -0.0213% - Complexity 32276 32352 +76 ================================================== Files 1490 1491 +1 Lines 125080 125430 +350 Branches 22525 22631 +106 ================================================== + Hits 84220 84429 +209 - Misses 33535 33618 +83 - Partials 7325 7383 +58 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2512?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...codehaus/groovy/tools/groovydoc/GroovyDocTool.java](https://app.codecov.io/gh/apache/groovy/pull/2512?src=pr&el=tree&filepath=subprojects%2Fgroovy-groovydoc%2Fsrc%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftools%2Fgroovydoc%2FGroovyDocTool.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWdyb292eWRvYy9zcmMvbWFpbi9qYXZhL29yZy9jb2RlaGF1cy9ncm9vdnkvdG9vbHMvZ3Jvb3Z5ZG9jL0dyb292eURvY1Rvb2wuamF2YQ==) | `80.3279% <77.7778%> (+0.3279%)` | :arrow_up: | | [...s/groovy/tools/groovydoc/SimpleGroovyClassDoc.java](https://app.codecov.io/gh/apache/groovy/pull/2512?src=pr&el=tree&filepath=subprojects%2Fgroovy-groovydoc%2Fsrc%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftools%2Fgroovydoc%2FSimpleGroovyClassDoc.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWdyb292eWRvYy9zcmMvbWFpbi9qYXZhL29yZy9jb2RlaGF1cy9ncm9vdnkvdG9vbHMvZ3Jvb3Z5ZG9jL1NpbXBsZUdyb292eUNsYXNzRG9jLmphdmE=) | `81.4229% <45.4546%> (-0.0586%)` | :arrow_down: | | [...groovy/tools/groovydoc/ExternalGroovyClassDoc.java](https://app.codecov.io/gh/apache/groovy/pull/2512?src=pr&el=tree&filepath=subprojects%2Fgroovy-groovydoc%2Fsrc%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftools%2Fgroovydoc%2FExternalGroovyClassDoc.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWdyb292eWRvYy9zcmMvbWFpbi9qYXZhL29yZy9jb2RlaGF1cy9ncm9vdnkvdG9vbHMvZ3Jvb3Z5ZG9jL0V4dGVybmFsR3Jvb3Z5Q2xhc3NEb2MuamF2YQ==) | `32.6087% <39.3939%> (+0.0786%)` | :arrow_up: | | [...g/codehaus/groovy/tools/groovydoc/TagRenderer.java](https://app.codecov.io/gh/apache/groovy/pull/2512?src=pr&el=tree&filepath=subprojects%2Fgroovy-groovydoc%2Fsrc%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftools%2Fgroovydoc%2FTagRenderer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWdyb292eWRvYy9zcmMvbWFpbi9qYXZhL29yZy9jb2RlaGF1cy9ncm9vdnkvdG9vbHMvZ3Jvb3Z5ZG9jL1RhZ1JlbmRlcmVyLmphdmE=) | `69.7466% <38.3333%> (-3.2437%)` | :arrow_down: | | [...groovy/tools/groovydoc/ExternalJavadocSupport.java](https://app.codecov.io/gh/apache/groovy/pull/2512?src=pr&el=tree&filepath=subprojects%2Fgroovy-groovydoc%2Fsrc%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftools%2Fgroovydoc%2FExternalJavadocSupport.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWdyb292eWRvYy9zcmMvbWFpbi9qYXZhL29yZy9jb2RlaGF1cy9ncm9vdnkvdG9vbHMvZ3Jvb3Z5ZG9jL0V4dGVybmFsSmF2YWRvY1N1cHBvcnQuamF2YQ==) | `65.6827% <65.6827%> (ø)` | | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2512/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > Add support for {@inheritDoc} in external JDK classes > ----------------------------------------------------- > > Key: GROOVY-11988 > URL: https://issues.apache.org/jira/browse/GROOVY-11988 > Project: Groovy > Issue Type: Improvement > Components: groovy-groovydoc > Reporter: Daniel Sun > Priority: Major > > Add support for resolving \{@inheritDoc\} tags in Groovy classes that extend > or implement external JDK classes/interfaces. Currently, when a Groovy class > uses \{@inheritDoc\} to inherit documentation from an overridden method in > java.lang.Object, java.util.Map, or other JDK classes, the tag is not > resolved and appears as a raw \{@inheritDoc\} token in the generated > documentation HTML. -- This message was sent by Atlassian Jira (v8.20.10#820010)
