[jira] [Commented] (GROOVY-12035) Avoid emitting unreachable GOTO in if/else bytecode generation

[ASF GitHub Bot (Jira)]

    [ 
https://issues.apache.org/jira/browse/GROOVY-12035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18083029#comment-18083029
 ] 

ASF GitHub Bot commented on GROOVY-12035:
-----------------------------------------

sonarqubecloud[bot] commented on PR #2556:
URL: https://github.com/apache/groovy/pull/2556#issuecomment-4524617473

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_groovy&pullRequest=2556) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_groovy&pullRequest=2556&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/project/issues?id=apache_groovy&pullRequest=2556&issueStatuses=ACCEPTED)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_groovy&pullRequest=2556&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [100.0% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_groovy&pullRequest=2556&metric=new_coverage&view=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_groovy&pullRequest=2556&metric=new_duplicated_lines_density&view=list)
  
     
   <!

> Avoid emitting unreachable GOTO in if/else bytecode generation
> --------------------------------------------------------------
>
>                 Key: GROOVY-12035
>                 URL: https://issues.apache.org/jira/browse/GROOVY-12035
>             Project: Groovy
>          Issue Type: Improvement
>            Reporter: Daniel Sun
>            Priority: Major
>
> StatementWriter.writeIfElse currently emits GOTO exitPath unconditionally 
> whenever an else branch exists. If the if branch is already non-fallthrough 
> (e.g., return, throw, or nested abrupt control flow), that jump is 
> unreachable and introduces dead bytecode in the generated method.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)