[
https://issues.apache.org/jira/browse/GROOVY-12036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18083110#comment-18083110
] ASF GitHub Bot commented on GROOVY-12036: ----------------------------------------- codecov-commenter commented on PR #2558: URL: https://github.com/apache/groovy/pull/2558#issuecomment-4527068146 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2558?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `44.23077%` with `29 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.1766%. Comparing base ([`121c860`](https://app.codecov.io/gh/apache/groovy/commit/121c8605f7994fcefb4f13f21b5a4a46b95ee84a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a1d2b84`](https://app.codecov.io/gh/apache/groovy/commit/a1d2b846d9b44b06d2ee0ccdfd8cb8a9622a875e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2558?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...rg/codehaus/groovy/runtime/ArrayGroovyMethods.java](https://app.codecov.io/gh/apache/groovy/pull/2558?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2FArrayGroovyMethods.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvQXJyYXlHcm9vdnlNZXRob2RzLmphdmE=) | 44.4444% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2558?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../codehaus/groovy/runtime/DefaultGroovyMethods.java](https://app.codecov.io/gh/apache/groovy/pull/2558?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2FDefaultGroovyMethods.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvRGVmYXVsdEdyb292eU1ldGhvZHMuamF2YQ==) | 0.0000% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2558?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...g/codehaus/groovy/runtime/StreamGroovyMethods.java](https://app.codecov.io/gh/apache/groovy/pull/2558?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2FStreamGroovyMethods.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvU3RyZWFtR3Jvb3Z5TWV0aG9kcy5qYXZh) | 50.0000% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2558?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2558?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2558 +/- ## ================================================== - Coverage 68.1879% 68.1766% -0.0114% - Complexity 33093 33107 +14 ================================================== Files 1508 1508 Lines 126147 126190 +43 Branches 22887 22889 +2 ================================================== + Hits 86017 86032 +15 - Misses 32489 32517 +28 Partials 7641 7641 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2558?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...s/groovy/runtime/ParallelCollectionExtensions.java](https://app.codecov.io/gh/apache/groovy/pull/2558?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2FParallelCollectionExtensions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvUGFyYWxsZWxDb2xsZWN0aW9uRXh0ZW5zaW9ucy5qYXZh) | `90.0000% <100.0000%> (+0.3448%)` | :arrow_up: | | [...g/codehaus/groovy/runtime/StreamGroovyMethods.java](https://app.codecov.io/gh/apache/groovy/pull/2558?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2FStreamGroovyMethods.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvU3RyZWFtR3Jvb3Z5TWV0aG9kcy5qYXZh) | `64.7059% <50.0000%> (-8.0214%)` | :arrow_down: | | [...rg/codehaus/groovy/runtime/ArrayGroovyMethods.java](https://app.codecov.io/gh/apache/groovy/pull/2558?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2FArrayGroovyMethods.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvQXJyYXlHcm9vdnlNZXRob2RzLmphdmE=) | `89.3516% <44.4444%> (-0.4861%)` | :arrow_down: | | [.../codehaus/groovy/runtime/DefaultGroovyMethods.java](https://app.codecov.io/gh/apache/groovy/pull/2558?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2FDefaultGroovyMethods.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvRGVmYXVsdEdyb292eU1ldGhvZHMuamF2YQ==) | `74.8952% <0.0000%> (-0.2100%)` | :arrow_down: | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2558/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > GDK: cache Collectors instances in StreamGroovyMethods and > ParallelCollectionExtensions > --------------------------------------------------------------------------------------- > > Key: GROOVY-12036 > URL: https://issues.apache.org/jira/browse/GROOVY-12036 > Project: Groovy > Issue Type: Improvement > Reporter: Paul King > Assignee: Paul King > Priority: Major > > Cache Collectors.toList() and Collectors.toSet() as static singletons in > StreamGroovyMethods and ParallelCollectionExtensions, eliminating per-call > collector allocation in 9 GDK call sites. > A benefit in Eclipse Collections as noted here: > https://donraab.medium.com/counting-and-collecting-collectors-d69b7c9aaca0 > Groovy is not a collections library but this is a very minor improvement with > no downside. -- This message was sent by Atlassian Jira (v8.20.10#820010)
