[
https://issues.apache.org/jira/browse/GROOVY-12052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18084635#comment-18084635
] ASF GitHub Bot commented on GROOVY-12052: ----------------------------------------- codecov-commenter commented on PR #2573: URL: https://github.com/apache/groovy/pull/2573#issuecomment-4585343444 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2573?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `88.88889%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.1795%. Comparing base ([`b092f36`](https://app.codecov.io/gh/apache/groovy/commit/b092f36815bddafca7e4f82e890f39929664bd79?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f6d8701`](https://app.codecov.io/gh/apache/groovy/commit/f6d87019510118fd1c39f5c872de7dd075a67c56?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 2 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2573?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ontracts/ast/visitor/AnnotationClosureVisitor.java](https://app.codecov.io/gh/apache/groovy/pull/2573?src=pr&el=tree&filepath=subprojects%2Fgroovy-contracts%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fcontracts%2Fast%2Fvisitor%2FAnnotationClosureVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWNvbnRyYWN0cy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ3Jvb3Z5L2NvbnRyYWN0cy9hc3QvdmlzaXRvci9Bbm5vdGF0aW9uQ2xvc3VyZVZpc2l0b3IuamF2YQ==) | 75.0000% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2573?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2573?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2573 +/- ## ================================================== + Coverage 68.1748% 68.1795% +0.0047% - Complexity 33161 33162 +1 ================================================== Files 1510 1510 Lines 126224 126230 +6 Branches 22893 22896 +3 ================================================== + Hits 86053 86063 +10 + Misses 32532 32528 -4 Partials 7639 7639 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2573?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...e/groovy/contracts/generation/CandidateChecks.java](https://app.codecov.io/gh/apache/groovy/pull/2573?src=pr&el=tree&filepath=subprojects%2Fgroovy-contracts%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fcontracts%2Fgeneration%2FCandidateChecks.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWNvbnRyYWN0cy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ3Jvb3Z5L2NvbnRyYWN0cy9nZW5lcmF0aW9uL0NhbmRpZGF0ZUNoZWNrcy5qYXZh) | `63.3333% <ø> (-1.1828%)` | :arrow_down: | | [...y/contracts/generation/PostconditionGenerator.java](https://app.codecov.io/gh/apache/groovy/pull/2573?src=pr&el=tree&filepath=subprojects%2Fgroovy-contracts%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fcontracts%2Fgeneration%2FPostconditionGenerator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWNvbnRyYWN0cy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ3Jvb3Z5L2NvbnRyYWN0cy9nZW5lcmF0aW9uL1Bvc3Rjb25kaXRpb25HZW5lcmF0b3IuamF2YQ==) | `97.8723% <100.0000%> (+0.1451%)` | :arrow_up: | | [...ontracts/ast/visitor/AnnotationClosureVisitor.java](https://app.codecov.io/gh/apache/groovy/pull/2573?src=pr&el=tree&filepath=subprojects%2Fgroovy-contracts%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fcontracts%2Fast%2Fvisitor%2FAnnotationClosureVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWNvbnRyYWN0cy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ3Jvb3Z5L2NvbnRyYWN0cy9hc3QvdmlzaXRvci9Bbm5vdGF0aW9uQ2xvc3VyZVZpc2l0b3IuamF2YQ==) | `90.1695% <75.0000%> (-0.2085%)` | :arrow_down: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2573/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > groovy-contracts @Ensures could support static methods > ------------------------------------------------------ > > Key: GROOVY-12052 > URL: https://issues.apache.org/jira/browse/GROOVY-12052 > Project: Groovy > Issue Type: Improvement > Reporter: Paul King > Assignee: Paul King > Priority: Major > > @Ensures supports an "old" notation for the (instance) value before the call. > Instead of banning @Ensures for static methods, we should just not allow the > "old" notation to appear in the contract. -- This message was sent by Atlassian Jira (v8.20.10#820010)
