[
https://issues.apache.org/jira/browse/GROOVY-12055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18084726#comment-18084726
] ASF GitHub Bot commented on GROOVY-12055: ----------------------------------------- codecov-commenter commented on PR #2579: URL: https://github.com/apache/groovy/pull/2579#issuecomment-4586521699 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2579?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `53.65854%` with `19 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.1832%. Comparing base ([`9a560a6`](https://app.codecov.io/gh/apache/groovy/commit/9a560a649487555ca6d58c7953d2d5290be3fee8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a5b273c`](https://app.codecov.io/gh/apache/groovy/commit/a5b273c561384d27477fd6de007c4f4b860e61e6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 3 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2579?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [src/main/java/groovy/util/ObjectGraphBuilder.java](https://app.codecov.io/gh/apache/groovy/pull/2579?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fgroovy%2Futil%2FObjectGraphBuilder.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9ncm9vdnkvdXRpbC9PYmplY3RHcmFwaEJ1aWxkZXIuamF2YQ==) | 40.0000% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2579?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/src/main/groovy/groovy/console/ui/Console.groovy](https://app.codecov.io/gh/apache/groovy/pull/2579?src=pr&el=tree&filepath=subprojects%2Fgroovy-console%2Fsrc%2Fmain%2Fgroovy%2Fgroovy%2Fconsole%2Fui%2FConsole.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWNvbnNvbGUvc3JjL21haW4vZ3Jvb3Z5L2dyb292eS9jb25zb2xlL3VpL0NvbnNvbGUuZ3Jvb3Z5) | 0.0000% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2579?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../main/groovy/groovy/console/ui/ThemeManager.groovy](https://app.codecov.io/gh/apache/groovy/pull/2579?src=pr&el=tree&filepath=subprojects%2Fgroovy-console%2Fsrc%2Fmain%2Fgroovy%2Fgroovy%2Fconsole%2Fui%2FThemeManager.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWNvbnNvbGUvc3JjL21haW4vZ3Jvb3Z5L2dyb292eS9jb25zb2xlL3VpL1RoZW1lTWFuYWdlci5ncm9vdnk=) | 75.0000% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2579?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/groovy/groovy/grape/maven/GrapeMaven.groovy](https://app.codecov.io/gh/apache/groovy/pull/2579?src=pr&el=tree&filepath=subprojects%2Fgroovy-grape-maven%2Fsrc%2Fmain%2Fgroovy%2Fgroovy%2Fgrape%2Fmaven%2FGrapeMaven.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWdyYXBlLW1hdmVuL3NyYy9tYWluL2dyb292eS9ncm9vdnkvZ3JhcGUvbWF2ZW4vR3JhcGVNYXZlbi5ncm9vdnk=) | 0.0000% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2579?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...apache/groovy/groovysh/jline/GroovyBuiltins.groovy](https://app.codecov.io/gh/apache/groovy/pull/2579?src=pr&el=tree&filepath=subprojects%2Fgroovy-groovysh%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fapache%2Fgroovy%2Fgroovysh%2Fjline%2FGroovyBuiltins.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWdyb292eXNoL3NyYy9tYWluL2dyb292eS9vcmcvYXBhY2hlL2dyb292eS9ncm9vdnlzaC9qbGluZS9Hcm9vdnlCdWlsdGlucy5ncm9vdnk=) | 0.0000% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2579?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [src/main/groovy/groovy/grape/GrapeUtil.groovy](https://app.codecov.io/gh/apache/groovy/pull/2579?src=pr&el=tree&filepath=src%2Fmain%2Fgroovy%2Fgroovy%2Fgrape%2FGrapeUtil.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vZ3Jvb3Z5L2dyb292eS9ncmFwZS9HcmFwZVV0aWwuZ3Jvb3Z5) | 0.0000% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2579?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...us/groovy/tools/javac/JavaStubCompilationUnit.java](https://app.codecov.io/gh/apache/groovy/pull/2579?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftools%2Fjavac%2FJavaStubCompilationUnit.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3Rvb2xzL2phdmFjL0phdmFTdHViQ29tcGlsYXRpb25Vbml0LmphdmE=) | 0.0000% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2579?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...in/groovy/groovy/console/ui/ConsoleTextEditor.java](https://app.codecov.io/gh/apache/groovy/pull/2579?src=pr&el=tree&filepath=subprojects%2Fgroovy-console%2Fsrc%2Fmain%2Fgroovy%2Fgroovy%2Fconsole%2Fui%2FConsoleTextEditor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWNvbnNvbGUvc3JjL21haW4vZ3Jvb3Z5L2dyb292eS9jb25zb2xlL3VpL0NvbnNvbGVUZXh0RWRpdG9yLmphdmE=) | 0.0000% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2579?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...groovy/tools/groovydoc/antlr4/GroovyDocParser.java](https://app.codecov.io/gh/apache/groovy/pull/2579?src=pr&el=tree&filepath=subprojects%2Fgroovy-groovydoc%2Fsrc%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftools%2Fgroovydoc%2Fantlr4%2FGroovyDocParser.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWdyb292eWRvYy9zcmMvbWFpbi9qYXZhL29yZy9jb2RlaGF1cy9ncm9vdnkvdG9vbHMvZ3Jvb3Z5ZG9jL2FudGxyNC9Hcm9vdnlEb2NQYXJzZXIuamF2YQ==) | 0.0000% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2579?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...apache/groovy/groovysh/jline/GroovyCommands.groovy](https://app.codecov.io/gh/apache/groovy/pull/2579?src=pr&el=tree&filepath=subprojects%2Fgroovy-groovysh%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fapache%2Fgroovy%2Fgroovysh%2Fjline%2FGroovyCommands.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWdyb292eXNoL3NyYy9tYWluL2dyb292eS9vcmcvYXBhY2hlL2dyb292eS9ncm9vdnlzaC9qbGluZS9Hcm9vdnlDb21tYW5kcy5ncm9vdnk=) | 0.0000% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2579?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | ... and [3 more](https://app.codecov.io/gh/apache/groovy/pull/2579?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2579?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2579 +/- ## ================================================== + Coverage 68.1789% 68.1832% +0.0043% - Complexity 33164 33167 +3 ================================================== Files 1511 1511 Lines 126237 126232 -5 Branches 22897 22897 ================================================== + Hits 86067 86069 +2 + Misses 32529 32525 -4 + Partials 7641 7638 -3 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2579?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../groovy/groovy/beans/ListenerListASTStubber.groovy](https://app.codecov.io/gh/apache/groovy/pull/2579?src=pr&el=tree&filepath=src%2Fmain%2Fgroovy%2Fgroovy%2Fbeans%2FListenerListASTStubber.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vZ3Jvb3Z5L2dyb292eS9iZWFucy9MaXN0ZW5lckxpc3RBU1RTdHViYmVyLmdyb292eQ==) | `67.5000% <100.0000%> (ø)` | | | [...va/org/apache/groovy/ast/tools/ClassNodeUtils.java](https://app.codecov.io/gh/apache/groovy/pull/2579?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fast%2Ftools%2FClassNodeUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9hc3QvdG9vbHMvQ2xhc3NOb2RlVXRpbHMuamF2YQ==) | `85.4839% <100.0000%> (ø)` | | | [...codehaus/groovy/control/CompilerConfiguration.java](https://app.codecov.io/gh/apache/groovy/pull/2579?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fcontrol%2FCompilerConfiguration.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NvbnRyb2wvQ29tcGlsZXJDb25maWd1cmF0aW9uLmphdmE=) | `72.6351% <100.0000%> (ø)` | | | [...oovy/ginq/provider/collection/GinqAstWalker.groovy](https://app.codecov.io/gh/apache/groovy/pull/2579?src=pr&el=tree&filepath=subprojects%2Fgroovy-ginq%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fapache%2Fgroovy%2Fginq%2Fprovider%2Fcollection%2FGinqAstWalker.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWdpbnEvc3JjL21haW4vZ3Jvb3Z5L29yZy9hcGFjaGUvZ3Jvb3Z5L2dpbnEvcHJvdmlkZXIvY29sbGVjdGlvbi9HaW5xQXN0V2Fsa2VyLmdyb292eQ==) | `90.2864% <100.0000%> (ø)` | | | [...codehaus/groovy/tools/groovydoc/GroovyDocTool.java](https://app.codecov.io/gh/apache/groovy/pull/2579?src=pr&el=tree&filepath=subprojects%2Fgroovy-groovydoc%2Fsrc%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftools%2Fgroovydoc%2FGroovyDocTool.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWdyb292eWRvYy9zcmMvbWFpbi9qYXZhL29yZy9jb2RlaGF1cy9ncm9vdnkvdG9vbHMvZ3Jvb3Z5ZG9jL0dyb292eURvY1Rvb2wuamF2YQ==) | `80.3279% <100.0000%> (ø)` | | | [...e/groovy/groovysh/jline/GroovyConsoleEngine.groovy](https://app.codecov.io/gh/apache/groovy/pull/2579?src=pr&el=tree&filepath=subprojects%2Fgroovy-groovysh%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fapache%2Fgroovy%2Fgroovysh%2Fjline%2FGroovyConsoleEngine.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWdyb292eXNoL3NyYy9tYWluL2dyb292eS9vcmcvYXBhY2hlL2dyb292eS9ncm9vdnlzaC9qbGluZS9Hcm9vdnlDb25zb2xlRW5naW5lLmdyb292eQ==) | `75.0000% <100.0000%> (ø)` | | | [...main/java/groovy/sql/ResultSetMetaDataWrapper.java](https://app.codecov.io/gh/apache/groovy/pull/2579?src=pr&el=tree&filepath=subprojects%2Fgroovy-sql%2Fsrc%2Fmain%2Fjava%2Fgroovy%2Fsql%2FResultSetMetaDataWrapper.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LXNxbC9zcmMvbWFpbi9qYXZhL2dyb292eS9zcWwvUmVzdWx0U2V0TWV0YURhdGFXcmFwcGVyLmphdmE=) | `70.5882% <100.0000%> (ø)` | | | [...jects/groovy-sql/src/main/java/groovy/sql/Sql.java](https://app.codecov.io/gh/apache/groovy/pull/2579?src=pr&el=tree&filepath=subprojects%2Fgroovy-sql%2Fsrc%2Fmain%2Fjava%2Fgroovy%2Fsql%2FSql.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LXNxbC9zcmMvbWFpbi9qYXZhL2dyb292eS9zcWwvU3FsLmphdmE=) | `67.7858% <100.0000%> (ø)` | | | [...oovy/text/markup/MarkupBuilderCodeTransformer.java](https://app.codecov.io/gh/apache/groovy/pull/2579?src=pr&el=tree&filepath=subprojects%2Fgroovy-templates%2Fsrc%2Fmain%2Fgroovy%2Fgroovy%2Ftext%2Fmarkup%2FMarkupBuilderCodeTransformer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LXRlbXBsYXRlcy9zcmMvbWFpbi9ncm9vdnkvZ3Jvb3Z5L3RleHQvbWFya3VwL01hcmt1cEJ1aWxkZXJDb2RlVHJhbnNmb3JtZXIuamF2YQ==) | `89.4737% <100.0000%> (ø)` | | | [...ovy/groovy/mock/interceptor/MockInterceptor.groovy](https://app.codecov.io/gh/apache/groovy/pull/2579?src=pr&el=tree&filepath=subprojects%2Fgroovy-test%2Fsrc%2Fmain%2Fgroovy%2Fgroovy%2Fmock%2Finterceptor%2FMockInterceptor.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LXRlc3Qvc3JjL21haW4vZ3Jvb3Z5L2dyb292eS9tb2NrL2ludGVyY2VwdG9yL01vY2tJbnRlcmNlcHRvci5ncm9vdnk=) | `68.4210% <100.0000%> (ø)` | | | ... and [14 more](https://app.codecov.io/gh/apache/groovy/pull/2579?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2579/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > Assess toLower/UpperCase calls which should use Locale.ROOT > ----------------------------------------------------------- > > Key: GROOVY-12055 > URL: https://issues.apache.org/jira/browse/GROOVY-12055 > Project: Groovy > Issue Type: Improvement > Reporter: Paul King > Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
