[
https://issues.apache.org/jira/browse/GROOVY-12064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18086203#comment-18086203
] ASF GitHub Bot commented on GROOVY-12064: ----------------------------------------- codecov-commenter commented on PR #2589: URL: https://github.com/apache/groovy/pull/2589#issuecomment-4626087327 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2589?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `87.71930%` with `7 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.2495%. Comparing base ([`13b009a`](https://app.codecov.io/gh/apache/groovy/commit/13b009a3243716c000d3ceb7db681883d98bf76b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b457d77`](https://app.codecov.io/gh/apache/groovy/commit/b457d77b43e172b364ad6350eff5c32d86969742?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2589?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...vy-json/src/main/java/groovy/json/JsonSlurper.java](https://app.codecov.io/gh/apache/groovy/pull/2589?src=pr&el=tree&filepath=subprojects%2Fgroovy-json%2Fsrc%2Fmain%2Fjava%2Fgroovy%2Fjson%2FJsonSlurper.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWpzb24vc3JjL21haW4vamF2YS9ncm9vdnkvanNvbi9Kc29uU2x1cnBlci5qYXZh) | 60.0000% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2589?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../src/main/java/groovy/json/JsonSlurperClassic.java](https://app.codecov.io/gh/apache/groovy/pull/2589?src=pr&el=tree&filepath=subprojects%2Fgroovy-json%2Fsrc%2Fmain%2Fjava%2Fgroovy%2Fjson%2FJsonSlurperClassic.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWpzb24vc3JjL21haW4vamF2YS9ncm9vdnkvanNvbi9Kc29uU2x1cnBlckNsYXNzaWMuamF2YQ==) | 88.2353% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2589?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/groovy/json/internal/BaseJsonParser.java](https://app.codecov.io/gh/apache/groovy/pull/2589?src=pr&el=tree&filepath=subprojects%2Fgroovy-json%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fjson%2Finternal%2FBaseJsonParser.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWpzb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9qc29uL2ludGVybmFsL0Jhc2VKc29uUGFyc2VyLmphdmE=) | 91.6667% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2589?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2589?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2589 +/- ## ================================================== + Coverage 68.2396% 68.2495% +0.0099% - Complexity 33337 33350 +13 ================================================== Files 1518 1518 Lines 126815 126861 +46 Branches 22995 22998 +3 ================================================== + Hits 86538 86582 +44 - Misses 32601 32603 +2 Partials 7676 7676 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2589?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...rg/apache/groovy/json/internal/JsonFastParser.java](https://app.codecov.io/gh/apache/groovy/pull/2589?src=pr&el=tree&filepath=subprojects%2Fgroovy-json%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fjson%2Finternal%2FJsonFastParser.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWpzb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9qc29uL2ludGVybmFsL0pzb25GYXN0UGFyc2VyLmphdmE=) | `76.6667% <100.0000%> (+0.6393%)` | :arrow_up: | | [...ache/groovy/json/internal/JsonParserCharArray.java](https://app.codecov.io/gh/apache/groovy/pull/2589?src=pr&el=tree&filepath=subprojects%2Fgroovy-json%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fjson%2Finternal%2FJsonParserCharArray.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWpzb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9qc29uL2ludGVybmFsL0pzb25QYXJzZXJDaGFyQXJyYXkuamF2YQ==) | `81.3954% <100.0000%> (+0.4430%)` | :arrow_up: | | [...org/apache/groovy/json/internal/JsonParserLax.java](https://app.codecov.io/gh/apache/groovy/pull/2589?src=pr&el=tree&filepath=subprojects%2Fgroovy-json%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fjson%2Finternal%2FJsonParserLax.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWpzb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9qc29uL2ludGVybmFsL0pzb25QYXJzZXJMYXguamF2YQ==) | `36.3036% <100.0000%> (+0.8521%)` | :arrow_up: | | [.../json/internal/JsonParserUsingCharacterSource.java](https://app.codecov.io/gh/apache/groovy/pull/2589?src=pr&el=tree&filepath=subprojects%2Fgroovy-json%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fjson%2Finternal%2FJsonParserUsingCharacterSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWpzb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9qc29uL2ludGVybmFsL0pzb25QYXJzZXJVc2luZ0NoYXJhY3RlclNvdXJjZS5qYXZh) | `86.1789% <100.0000%> (+0.3455%)` | :arrow_up: | | [...rg/apache/groovy/json/internal/BaseJsonParser.java](https://app.codecov.io/gh/apache/groovy/pull/2589?src=pr&el=tree&filepath=subprojects%2Fgroovy-json%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fjson%2Finternal%2FBaseJsonParser.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWpzb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9qc29uL2ludGVybmFsL0Jhc2VKc29uUGFyc2VyLmphdmE=) | `74.6835% <91.6667%> (+3.0417%)` | :arrow_up: | | [.../src/main/java/groovy/json/JsonSlurperClassic.java](https://app.codecov.io/gh/apache/groovy/pull/2589?src=pr&el=tree&filepath=subprojects%2Fgroovy-json%2Fsrc%2Fmain%2Fjava%2Fgroovy%2Fjson%2FJsonSlurperClassic.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWpzb24vc3JjL21haW4vamF2YS9ncm9vdnkvanNvbi9Kc29uU2x1cnBlckNsYXNzaWMuamF2YQ==) | `43.6709% <88.2353%> (+2.8546%)` | :arrow_up: | | [...vy-json/src/main/java/groovy/json/JsonSlurper.java](https://app.codecov.io/gh/apache/groovy/pull/2589?src=pr&el=tree&filepath=subprojects%2Fgroovy-json%2Fsrc%2Fmain%2Fjava%2Fgroovy%2Fjson%2FJsonSlurper.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWpzb24vc3JjL21haW4vamF2YS9ncm9vdnkvanNvbi9Kc29uU2x1cnBlci5qYXZh) | `51.5152% <60.0000%> (+3.1635%)` | :arrow_up: | ... and [8 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2589/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > Provide a maximum depth threshold for parsing deeply nested JSON documents > -------------------------------------------------------------------------- > > Key: GROOVY-12064 > URL: https://issues.apache.org/jira/browse/GROOVY-12064 > Project: Groovy > Issue Type: Improvement > Reporter: Paul King > Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
