[
https://issues.apache.org/jira/browse/GROOVY-12067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18086845#comment-18086845
] ASF GitHub Bot commented on GROOVY-12067: ----------------------------------------- codecov-commenter commented on PR #2595: URL: https://github.com/apache/groovy/pull/2595#issuecomment-4645525442 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2595?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `75.00000%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.3121%. Comparing base ([`96ab17a`](https://app.codecov.io/gh/apache/groovy/commit/96ab17aee5d15c64ea6215ac4228d9f8a1a12bb8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b96eeff`](https://app.codecov.io/gh/apache/groovy/commit/b96eeffbf06865a027f86b2b61d8b814d385f0ee?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2595?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [src/main/java/groovy/lang/IntRange.java](https://app.codecov.io/gh/apache/groovy/pull/2595?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fgroovy%2Flang%2FIntRange.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9ncm9vdnkvbGFuZy9JbnRSYW5nZS5qYXZh) | 75.0000% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2595?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2595?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2595 +/- ## ================================================== + Coverage 68.3040% 68.3121% +0.0081% - Complexity 33394 33399 +5 ================================================== Files 1518 1518 Lines 126874 126878 +4 Branches 23002 23004 +2 ================================================== + Hits 86660 86673 +13 + Misses 32529 32522 -7 + Partials 7685 7683 -2 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2595?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [src/main/java/groovy/lang/IntRange.java](https://app.codecov.io/gh/apache/groovy/pull/2595?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fgroovy%2Flang%2FIntRange.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9ncm9vdnkvbGFuZy9JbnRSYW5nZS5qYXZh) | `72.3404% <75.0000%> (+0.0777%)` | :arrow_up: | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2595/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > IntRange.containsWithinBounds delegates to contains, breaking the > continuous-bounds contract > -------------------------------------------------------------------------------------------- > > Key: GROOVY-12067 > URL: https://issues.apache.org/jira/browse/GROOVY-12067 > Project: Groovy > Issue Type: Bug > Reporter: Paul King > Assignee: Paul King > Priority: Major > Labels: breaking > > We had an invalid shortcut from day 1 without sufficient test coverage. -- This message was sent by Atlassian Jira (v8.20.10#820010)
