[
https://issues.apache.org/jira/browse/GROOVY-12134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18093948#comment-18093948
] ASF GitHub Bot commented on GROOVY-12134: ----------------------------------------- codecov-commenter commented on PR #2670: URL: https://github.com/apache/groovy/pull/2670#issuecomment-4891089306 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2670?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.5582%. Comparing base ([`77ca2fa`](https://app.codecov.io/gh/apache/groovy/commit/77ca2fa03c32f16a909b9ceffa244e1832415328?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c15f84a`](https://app.codecov.io/gh/apache/groovy/commit/c15f84a2593cf3f666a87c52f920e71ef0124ef3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 5 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2670?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...us/groovy/transform/DelegateASTTransformation.java](https://app.codecov.io/gh/apache/groovy/pull/2670?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2FDelegateASTTransformation.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9EZWxlZ2F0ZUFTVFRyYW5zZm9ybWF0aW9uLmphdmE=) | 0.0000% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2670?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2670?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2670 +/- ## ================================================== - Coverage 68.5684% 68.5582% -0.0103% - Complexity 33800 33808 +8 ================================================== Files 1524 1524 Lines 128091 128170 +79 Branches 23283 23293 +10 ================================================== + Hits 87830 87871 +41 - Misses 32467 32497 +30 - Partials 7794 7802 +8 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2670?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...us/groovy/transform/DelegateASTTransformation.java](https://app.codecov.io/gh/apache/groovy/pull/2670?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2FDelegateASTTransformation.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9EZWxlZ2F0ZUFTVFRyYW5zZm9ybWF0aW9uLmphdmE=) | `87.2951% <0.0000%> (-0.4098%)` | :arrow_down: | ... and [12 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2670/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > @Delegate regression: fails to skip a final method inherited from a > precompiled superclass > ------------------------------------------------------------------------------------------ > > Key: GROOVY-12134 > URL: https://issues.apache.org/jira/browse/GROOVY-12134 > Project: Groovy > Issue Type: Bug > Affects Versions: 5.x > Reporter: James Daugherty > Priority: Major > > I'm upgrading the Grails Spring Security plugin to Groovy 5 and noticed > compilation was failing with an `@Delegate` involving a final method. > > Reproducer project is here: > [https://github.com/jdaugherty/groovy-final-delegate-bug] > > As a work around, ignoring the method manually makes compile succeed. > h1. -- This message was sent by Atlassian Jira (v8.20.10#820010)
