[
https://issues.apache.org/jira/browse/GROOVY-12138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18094455#comment-18094455
] ASF GitHub Bot commented on GROOVY-12138: ----------------------------------------- codecov-commenter commented on PR #2674: URL: https://github.com/apache/groovy/pull/2674#issuecomment-4910322272 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2674?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `9.80392%` with `92 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.6181%. Comparing base ([`c6fa475`](https://app.codecov.io/gh/apache/groovy/commit/c6fa475e9eef061c186d88e0fc3079241ff50ed2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`89b0533`](https://app.codecov.io/gh/apache/groovy/commit/89b0533c4b3591220aac325ad8dcf9f29968d35b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 3 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2674?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...java/org/codehaus/groovy/vmplugin/v8/Selector.java](https://app.codecov.io/gh/apache/groovy/pull/2674?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fvmplugin%2Fv8%2FSelector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3ZtcGx1Z2luL3Y4L1NlbGVjdG9yLmphdmE=) | 0.0000% | [59 Missing :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2674?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../groovy/classgen/asm/indy/InvokeDynamicWriter.java](https://app.codecov.io/gh/apache/groovy/pull/2674?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fclassgen%2Fasm%2Findy%2FInvokeDynamicWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NsYXNzZ2VuL2FzbS9pbmR5L0ludm9rZUR5bmFtaWNXcml0ZXIuamF2YQ==) | 0.0000% | [19 Missing :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2674?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/codehaus/groovy/reflection/CachedField.java](https://app.codecov.io/gh/apache/groovy/pull/2674?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Freflection%2FCachedField.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3JlZmxlY3Rpb24vQ2FjaGVkRmllbGQuamF2YQ==) | 0.0000% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2674?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...s/groovy/classgen/asm/indy/IndyCallSiteWriter.java](https://app.codecov.io/gh/apache/groovy/pull/2674?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fclassgen%2Fasm%2Findy%2FIndyCallSiteWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NsYXNzZ2VuL2FzbS9pbmR5L0luZHlDYWxsU2l0ZVdyaXRlci5qYXZh) | 42.8571% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2674?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2674?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2674 +/- ## ================================================== + Coverage 68.5934% 68.6181% +0.0247% - Complexity 33951 34105 +154 ================================================== Files 1535 1536 +1 Lines 128543 129001 +458 Branches 23335 23390 +55 ================================================== + Hits 88172 88518 +346 - Misses 32555 32653 +98 - Partials 7816 7830 +14 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2674?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...rg/codehaus/groovy/classgen/AsmClassGenerator.java](https://app.codecov.io/gh/apache/groovy/pull/2674?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fclassgen%2FAsmClassGenerator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NsYXNzZ2VuL0FzbUNsYXNzR2VuZXJhdG9yLmphdmE=) | `85.0616% <100.0000%> (+0.0544%)` | :arrow_up: | | [...g/codehaus/groovy/classgen/asm/CallSiteWriter.java](https://app.codecov.io/gh/apache/groovy/pull/2674?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fclassgen%2Fasm%2FCallSiteWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NsYXNzZ2VuL2FzbS9DYWxsU2l0ZVdyaXRlci5qYXZh) | `84.7619% <100.0000%> (+0.2959%)` | :arrow_up: | | [...vy/vmplugin/v8/IndyGuardsFiltersAndSignatures.java](https://app.codecov.io/gh/apache/groovy/pull/2674?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fvmplugin%2Fv8%2FIndyGuardsFiltersAndSignatures.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3ZtcGx1Z2luL3Y4L0luZHlHdWFyZHNGaWx0ZXJzQW5kU2lnbmF0dXJlcy5qYXZh) | `92.1875% <100.0000%> (+0.3842%)` | :arrow_up: | | [...s/groovy/classgen/asm/indy/IndyCallSiteWriter.java](https://app.codecov.io/gh/apache/groovy/pull/2674?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fclassgen%2Fasm%2Findy%2FIndyCallSiteWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NsYXNzZ2VuL2FzbS9pbmR5L0luZHlDYWxsU2l0ZVdyaXRlci5qYXZh) | `63.6364% <42.8571%> (-9.6970%)` | :arrow_down: | | [...va/org/codehaus/groovy/reflection/CachedField.java](https://app.codecov.io/gh/apache/groovy/pull/2674?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Freflection%2FCachedField.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3JlZmxlY3Rpb24vQ2FjaGVkRmllbGQuamF2YQ==) | `54.5454% <0.0000%> (-16.0428%)` | :arrow_down: | | [.../groovy/classgen/asm/indy/InvokeDynamicWriter.java](https://app.codecov.io/gh/apache/groovy/pull/2674?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fclassgen%2Fasm%2Findy%2FInvokeDynamicWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NsYXNzZ2VuL2FzbS9pbmR5L0ludm9rZUR5bmFtaWNXcml0ZXIuamF2YQ==) | `80.8743% <0.0000%> (-9.3696%)` | :arrow_down: | | [...java/org/codehaus/groovy/vmplugin/v8/Selector.java](https://app.codecov.io/gh/apache/groovy/pull/2674?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fvmplugin%2Fv8%2FSelector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3ZtcGx1Z2luL3Y4L1NlbGVjdG9yLmphdmE=) | `72.5979% <0.0000%> (-8.3545%)` | :arrow_down: | ... and [9 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2674/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > emit invokedynamic call sites for property writes > ------------------------------------------------- > > Key: GROOVY-12138 > URL: https://issues.apache.org/jira/browse/GROOVY-12138 > Project: Groovy > Issue Type: Improvement > Reporter: Paul King > Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
