paulk-asert commented on code in PR #2673:
URL: https://github.com/apache/groovy/pull/2673#discussion_r3549141822
##########
src/main/java/org/codehaus/groovy/vmplugin/v8/Selector.java:
##########
@@ -1226,6 +1251,35 @@ void buildInvokeHandle() {
addExceptionHandler();
}
}
+
+ @Override
+ MetaMethod selectForColdReflection() {
+ // defensive: the cold tier is only for plain method calls; the
+ // fallback gates on CallType.METHOD, so subclasses (CastSelector,
+ // InterfaceSelector) are never asked, but make it explicit here
+ if (callType != CallType.METHOD) return null;
Review Comment:
(GroovyBugError): Agreed and done — reaching this with a non-METHOD call
type would mean the fallback's gate broke, so it now throws GroovyBugError.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
