[
https://issues.apache.org/jira/browse/GROOVY-12168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18096928#comment-18096928
] ASF GitHub Bot commented on GROOVY-12168: ----------------------------------------- codecov-commenter commented on PR #2715: URL: https://github.com/apache/groovy/pull/2715#issuecomment-4997885827 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2715?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `89.47368%` with `2 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 69.1248%. Comparing base ([`538f618`](https://app.codecov.io/gh/apache/groovy/commit/538f618b3d817f1bb0e1035646e94e64c4d81144?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8ff73d7`](https://app.codecov.io/gh/apache/groovy/commit/8ff73d7c1c2df932b6ee9af5b70670eaa3c5b39e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2715?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...a/org/apache/groovy/json/internal/CharScanner.java](https://app.codecov.io/gh/apache/groovy/pull/2715?src=pr&el=tree&filepath=subprojects%2Fgroovy-json%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fjson%2Finternal%2FCharScanner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWpzb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9qc29uL2ludGVybmFsL0NoYXJTY2FubmVyLmphdmE=) | 88.8889% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2715?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...a/org/apache/groovy/json/internal/NumberValue.java](https://app.codecov.io/gh/apache/groovy/pull/2715?src=pr&el=tree&filepath=subprojects%2Fgroovy-json%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fjson%2Finternal%2FNumberValue.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWpzb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9qc29uL2ludGVybmFsL051bWJlclZhbHVlLmphdmE=) | 0.0000% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2715?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2715?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2715 +/- ## ================================================== + Coverage 69.1087% 69.1248% +0.0161% - Complexity 34271 34281 +10 ================================================== Files 1537 1537 Lines 129483 129489 +6 Branches 23552 23552 ================================================== + Hits 89484 89509 +25 + Misses 31969 31946 -23 - Partials 8030 8034 +4 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2715?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../json/internal/JsonParserUsingCharacterSource.java](https://app.codecov.io/gh/apache/groovy/pull/2715?src=pr&el=tree&filepath=subprojects%2Fgroovy-json%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fjson%2Finternal%2FJsonParserUsingCharacterSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWpzb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9qc29uL2ludGVybmFsL0pzb25QYXJzZXJVc2luZ0NoYXJhY3RlclNvdXJjZS5qYXZh) | `87.2000% <100.0000%> (+0.3148%)` | :arrow_up: | | [...a/org/apache/groovy/json/internal/CharScanner.java](https://app.codecov.io/gh/apache/groovy/pull/2715?src=pr&el=tree&filepath=subprojects%2Fgroovy-json%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fjson%2Finternal%2FCharScanner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWpzb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9qc29uL2ludGVybmFsL0NoYXJTY2FubmVyLmphdmE=) | `75.6198% <88.8889%> (-0.1124%)` | :arrow_down: | | [...a/org/apache/groovy/json/internal/NumberValue.java](https://app.codecov.io/gh/apache/groovy/pull/2715?src=pr&el=tree&filepath=subprojects%2Fgroovy-json%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fjson%2Finternal%2FNumberValue.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWpzb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9qc29uL2ludGVybmFsL051bWJlclZhbHVlLmphdmE=) | `80.0000% <0.0000%> (ø)` | | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2715/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > Improve exception handling consistency for numbers during JSON parsing > ---------------------------------------------------------------------- > > Key: GROOVY-12168 > URL: https://issues.apache.org/jira/browse/GROOVY-12168 > Project: Groovy > Issue Type: Improvement > Reporter: Paul King > Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
