paulk-asert commented on PR #2773: URL: https://github.com/apache/groovy/pull/2773#issuecomment-5238861578
AI read below: > * Breaking-change documentation. In dynamic mode this is a silent behavior change: code that previously read a pattern variable in an else-block, after an if, or in a || RHS now gets a dynamic property lookup → MissingPropertyException at runtime, with no compile-time warning. That's the right semantics and 6.0 is the right time, but the PR contains no release-notes/docs change. It should be in the beta-2 notes and the Groovy 6 breaking-changes list. I added the `breaking` label in Jira which I use to cross check release notes - so I can add that in next edit I do. > * Two smaller observations worth a review comment but not blocking: while loops deliberately get only partial flow scoping (no after-loop introduction as Java has — fine, but should be an explicit documented decision), and writeIfElse changed the breakable-frame region (it now wraps both arms where it previously ended before the else block) — GROOVY-7463 tests pass, but the labeled-break-from-else behavior change should be confirmed as intentional. > > **Bottom line**: technically strong and converging fast, but let Jochen sign off on the redesign -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
