[
https://issues.apache.org/jira/browse/GROOVY-10355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18105734#comment-18105734
] ASF GitHub Bot commented on GROOVY-10355: ----------------------------------------- codecov-commenter commented on PR #2817: URL: https://github.com/apache/groovy/pull/2817#issuecomment-5335977727 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2817?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `75.00000%` with `32 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 70.1831%. Comparing base ([`55dcfb9`](https://app.codecov.io/gh/apache/groovy/commit/55dcfb9939e8ccc00c05ab9b94cc67e6e7894a90?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`af2b7b6`](https://app.codecov.io/gh/apache/groovy/commit/af2b7b6883fd7dd87ddd335a0f44956149324af5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 6 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2817?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...va/org/apache/groovy/parser/antlr4/AstBuilder.java](https://app.codecov.io/gh/apache/groovy/pull/2817?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fparser%2Fantlr4%2FAstBuilder.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9wYXJzZXIvYW50bHI0L0FzdEJ1aWxkZXIuamF2YQ==) | 73.9837% | [16 Missing and 16 partials :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2817?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2817?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2817 +/- ## ================================================== - Coverage 70.1846% 70.1831% -0.0015% - Complexity 35846 35910 +64 ================================================== Files 1562 1562 Lines 132542 132663 +121 Branches 24379 24416 +37 ================================================== + Hits 93024 93107 +83 - Misses 31109 31125 +16 - Partials 8409 8431 +22 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2817?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...va/org/codehaus/groovy/control/ResolveVisitor.java](https://app.codecov.io/gh/apache/groovy/pull/2817?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fcontrol%2FResolveVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NvbnRyb2wvUmVzb2x2ZVZpc2l0b3IuamF2YQ==) | `90.3305% <100.0000%> (+0.0476%)` | :arrow_up: | | [...va/org/apache/groovy/parser/antlr4/AstBuilder.java](https://app.codecov.io/gh/apache/groovy/pull/2817?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fparser%2Fantlr4%2FAstBuilder.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9wYXJzZXIvYW50bHI0L0FzdEJ1aWxkZXIuamF2YQ==) | `86.8132% <73.9837%> (-0.7082%)` | :arrow_down: | ... and [7 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2817/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > Compiler interpret variable name as class name when in parentheses. > -------------------------------------------------------------------- > > Key: GROOVY-10355 > URL: https://issues.apache.org/jira/browse/GROOVY-10355 > Project: Groovy > Issue Type: Bug > Components: parser-antlr4 > Affects Versions: 3.0.0, 4.0.0, 5.0.0 > Environment: JDK 11.0.12 > Reporter: Olof Asbrink > Priority: Major > Attachments: GROOVY-10355-Assessment.pdf, screenshot-1.png, > screenshot-2.png > > > This behavior seems unexpected: > {code:java} > String b = "B" > System.out.println("A" + (b) + "C") > {code} > Throws this exception: > {code:java} > org.codehaus.groovy.control.MultipleCompilationErrorsException: startup > failed: > /tmp/repo1.gm: 2: unable to resolve class b > @ line 2, column 26. > System.out.println("A" + (b) + "C") > ^{code} > However these examples work: > {code:java} > String b = "B" > System.out.println("A" + b + "C") > {code} > and > {code:java} > String b = "B" > System.out.println("A" + (b)) > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010)
