[
https://issues.apache.org/jira/browse/GROOVY-12329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18110538#comment-18110538
] ASF GitHub Bot commented on GROOVY-12329: ----------------------------------------- codecov-commenter commented on PR #2856: URL: https://github.com/apache/groovy/pull/2856#issuecomment-5506138363 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2856?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `94.28571%` with `2 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 70.8032%. Comparing base ([`c251a83`](https://app.codecov.io/gh/apache/groovy/commit/c251a839e3e6182d068b1981aed2a4c4d635371d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`34080e7`](https://app.codecov.io/gh/apache/groovy/commit/34080e75568e03928ca780ae13b756f1a5994d60?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2856?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...vy-json/src/main/java/groovy/json/JsonSlurper.java](https://app.codecov.io/gh/apache/groovy/pull/2856?src=pr&el=tree&filepath=subprojects%2Fgroovy-json%2Fsrc%2Fmain%2Fjava%2Fgroovy%2Fjson%2FJsonSlurper.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWpzb24vc3JjL21haW4vamF2YS9ncm9vdnkvanNvbi9Kc29uU2x1cnBlci5qYXZh) | 83.3333% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/groovy/json/internal/BaseJsonParser.java](https://app.codecov.io/gh/apache/groovy/pull/2856?src=pr&el=tree&filepath=subprojects%2Fgroovy-json%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fjson%2Finternal%2FBaseJsonParser.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWpzb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9qc29uL2ludGVybmFsL0Jhc2VKc29uUGFyc2VyLmphdmE=) | 83.3333% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2856 +/- ## ================================================== + Coverage 70.8002% 70.8032% +0.0030% - Complexity 36979 36993 +14 ================================================== Files 1576 1576 Lines 134792 134823 +31 Branches 24954 24955 +1 ================================================== + Hits 95433 95459 +26 - Misses 30756 30764 +8 + Partials 8603 8600 -3 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2856?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../src/main/java/groovy/json/JsonSlurperClassic.java](https://app.codecov.io/gh/apache/groovy/pull/2856?src=pr&el=tree&filepath=subprojects%2Fgroovy-json%2Fsrc%2Fmain%2Fjava%2Fgroovy%2Fjson%2FJsonSlurperClassic.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWpzb24vc3JjL21haW4vamF2YS9ncm9vdnkvanNvbi9Kc29uU2x1cnBlckNsYXNzaWMuamF2YQ==) | `47.9290% <100.0000%> (+3.6252%)` | :arrow_up: | | [...a/org/apache/groovy/json/internal/CharScanner.java](https://app.codecov.io/gh/apache/groovy/pull/2856?src=pr&el=tree&filepath=subprojects%2Fgroovy-json%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fjson%2Finternal%2FCharScanner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWpzb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9qc29uL2ludGVybmFsL0NoYXJTY2FubmVyLmphdmE=) | `76.5182% <100.0000%> (+0.8984%)` | :arrow_up: | | [...rg/apache/groovy/json/internal/JsonFastParser.java](https://app.codecov.io/gh/apache/groovy/pull/2856?src=pr&el=tree&filepath=subprojects%2Fgroovy-json%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fjson%2Finternal%2FJsonFastParser.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWpzb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9qc29uL2ludGVybmFsL0pzb25GYXN0UGFyc2VyLmphdmE=) | `77.6316% <100.0000%> (+0.1481%)` | :arrow_up: | | [...ache/groovy/json/internal/JsonParserCharArray.java](https://app.codecov.io/gh/apache/groovy/pull/2856?src=pr&el=tree&filepath=subprojects%2Fgroovy-json%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fjson%2Finternal%2FJsonParserCharArray.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWpzb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9qc29uL2ludGVybmFsL0pzb25QYXJzZXJDaGFyQXJyYXkuamF2YQ==) | `81.2866% <100.0000%> (ø)` | | | [...org/apache/groovy/json/internal/JsonParserLax.java](https://app.codecov.io/gh/apache/groovy/pull/2856?src=pr&el=tree&filepath=subprojects%2Fgroovy-json%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fjson%2Finternal%2FJsonParserLax.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWpzb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9qc29uL2ludGVybmFsL0pzb25QYXJzZXJMYXguamF2YQ==) | `72.1312% <100.0000%> (+0.0917%)` | :arrow_up: | | [.../json/internal/JsonParserUsingCharacterSource.java](https://app.codecov.io/gh/apache/groovy/pull/2856?src=pr&el=tree&filepath=subprojects%2Fgroovy-json%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fjson%2Finternal%2FJsonParserUsingCharacterSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWpzb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9qc29uL2ludGVybmFsL0pzb25QYXJzZXJVc2luZ0NoYXJhY3RlclNvdXJjZS5qYXZh) | `87.3016% <100.0000%> (+0.1016%)` | :arrow_up: | | [...vy-json/src/main/java/groovy/json/JsonSlurper.java](https://app.codecov.io/gh/apache/groovy/pull/2856?src=pr&el=tree&filepath=subprojects%2Fgroovy-json%2Fsrc%2Fmain%2Fjava%2Fgroovy%2Fjson%2FJsonSlurper.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWpzb24vc3JjL21haW4vamF2YS9ncm9vdnkvanNvbi9Kc29uU2x1cnBlci5qYXZh) | `53.3333% <83.3333%> (+1.8182%)` | :arrow_up: | | [...rg/apache/groovy/json/internal/BaseJsonParser.java](https://app.codecov.io/gh/apache/groovy/pull/2856?src=pr&el=tree&filepath=subprojects%2Fgroovy-json%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fjson%2Finternal%2FBaseJsonParser.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWpzb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9qc29uL2ludGVybmFsL0Jhc2VKc29uUGFyc2VyLmphdmE=) | `75.2941% <83.3333%> (+0.6106%)` | :arrow_up: | ... and [10 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2856/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > JsonSlurper: bound the length of a JSON number token > ---------------------------------------------------- > > Key: GROOVY-12329 > URL: https://issues.apache.org/jira/browse/GROOVY-12329 > Project: Groovy > Issue Type: Improvement > Reporter: Paul King > Assignee: Paul King > Priority: Major > Labels: breaking > -- This message was sent by Atlassian Jira (v8.20.10#820010)
