[
https://issues.apache.org/jira/browse/GROOVY-12338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18110738#comment-18110738
] ASF GitHub Bot commented on GROOVY-12338: ----------------------------------------- codecov-commenter commented on PR #2863: URL: https://github.com/apache/groovy/pull/2863#issuecomment-5512517037 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2863?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `66.66667%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 70.8129%. Comparing base ([`ee41588`](https://app.codecov.io/gh/apache/groovy/commit/ee415888471bd650774c1b02f70e1e13a942b74d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a83e114`](https://app.codecov.io/gh/apache/groovy/commit/a83e11491909b06771ce9cfd6eff3d08a7cef0f6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2863?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../main/groovy/groovy/xml/StreamingSAXBuilder.groovy](https://app.codecov.io/gh/apache/groovy/pull/2863?src=pr&el=tree&filepath=subprojects%2Fgroovy-xml%2Fsrc%2Fmain%2Fgroovy%2Fgroovy%2Fxml%2FStreamingSAXBuilder.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LXhtbC9zcmMvbWFpbi9ncm9vdnkvZ3Jvb3Z5L3htbC9TdHJlYW1pbmdTQVhCdWlsZGVyLmdyb292eQ==) | 66.6667% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2863?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2863?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2863 +/- ## ================================================== + Coverage 70.8093% 70.8129% +0.0036% + Complexity 36992 36991 -1 ================================================== Files 1576 1576 Lines 134793 134796 +3 Branches 24965 24965 ================================================== + Hits 95446 95453 +7 + Misses 30740 30735 -5 - Partials 8607 8608 +1 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2863?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../main/groovy/groovy/xml/StreamingSAXBuilder.groovy](https://app.codecov.io/gh/apache/groovy/pull/2863?src=pr&el=tree&filepath=subprojects%2Fgroovy-xml%2Fsrc%2Fmain%2Fgroovy%2Fgroovy%2Fxml%2FStreamingSAXBuilder.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LXhtbC9zcmMvbWFpbi9ncm9vdnkvZ3Jvb3Z5L3htbC9TdHJlYW1pbmdTQVhCdWlsZGVyLmdyb292eQ==) | `59.7561% <66.6667%> (+4.0599%)` | :arrow_up: | ... and [9 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2863/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > harden StreamingSAXBuilder comment/PI breakout validation > --------------------------------------------------------- > > Key: GROOVY-12338 > URL: https://issues.apache.org/jira/browse/GROOVY-12338 > Project: Groovy > Issue Type: Improvement > Reporter: Paul King > Assignee: Paul King > Priority: Major > Labels: breaking > > Input like "--" within a comment was previously accepted, though produced > invalid XML if serialized. It now throws GroovyRuntimeException. -- This message was sent by Atlassian Jira (v8.20.10#820010)
