[ 
https://issues.apache.org/jira/browse/GROOVY-12348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18110954#comment-18110954
 ] 

ASF GitHub Bot commented on GROOVY-12348:
-----------------------------------------

codecov-commenter commented on PR #2870:
URL: https://github.com/apache/groovy/pull/2870#issuecomment-5520753777

   ## 
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2870?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   :x: Patch coverage is `71.05263%` with `11 lines` in your changes missing 
coverage. Please review.
   :white_check_mark: Project coverage is 70.9463%. Comparing base 
([`2ca5668`](https://app.codecov.io/gh/apache/groovy/commit/2ca56681c42e8b0599a878de848098df2155d25e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
 to head 
([`2034875`](https://app.codecov.io/gh/apache/groovy/commit/2034875208df466a8c6aa6a4f98684308d3712fd?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 20 commits behind head on master.
   
   | [Files with missing 
lines](https://app.codecov.io/gh/apache/groovy/pull/2870?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | Patch % | Lines |
   |---|---|---|
   | 
[...roovy/jmx/builder/JmxServerConnectorFactory.groovy](https://app.codecov.io/gh/apache/groovy/pull/2870?src=pr&el=tree&filepath=subprojects%2Fgroovy-jmx%2Fsrc%2Fmain%2Fgroovy%2Fgroovy%2Fjmx%2Fbuilder%2FJmxServerConnectorFactory.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWpteC9zcmMvbWFpbi9ncm9vdnkvZ3Jvb3Z5L2pteC9idWlsZGVyL0pteFNlcnZlckNvbm5lY3RvckZhY3RvcnkuZ3Jvb3Z5)
 | 71.0526% | [3 Missing and 8 partials :warning: 
](https://app.codecov.io/gh/apache/groovy/pull/2870?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   [![Impacted file tree 
graph](https://app.codecov.io/gh/apache/groovy/pull/2870/graphs/tree.svg?width=650&height=150&src=pr&token=1r45138NfQ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)](https://app.codecov.io/gh/apache/groovy/pull/2870?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   ```diff
   @@                Coverage Diff                 @@
   ##               master      #2870        +/-   ##
   ==================================================
   + Coverage     70.9418%   70.9463%   +0.0045%     
   - Complexity      37054      37084        +30     
   ==================================================
     Files            1576       1576                
     Lines          134857     134933        +76     
     Branches        24973      24997        +24     
   ==================================================
   + Hits            95670      95730        +60     
   - Misses          30530      30536         +6     
   - Partials         8657       8667        +10     
   ```
   
   | [Files with missing 
lines](https://app.codecov.io/gh/apache/groovy/pull/2870?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | Coverage Δ | |
   |---|---|---|
   | 
[...roovy/jmx/builder/JmxServerConnectorFactory.groovy](https://app.codecov.io/gh/apache/groovy/pull/2870?src=pr&el=tree&filepath=subprojects%2Fgroovy-jmx%2Fsrc%2Fmain%2Fgroovy%2Fgroovy%2Fjmx%2Fbuilder%2FJmxServerConnectorFactory.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWpteC9zcmMvbWFpbi9ncm9vdnkvZ3Jvb3Z5L2pteC9idWlsZGVyL0pteFNlcnZlckNvbm5lY3RvckZhY3RvcnkuZ3Jvb3Z5)
 | `64.1304% <71.0526%> (+4.8712%)` | :arrow_up: |
   
   ... and [8 files with indirect coverage 
changes](https://app.codecov.io/gh/apache/groovy/pull/2870/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test 
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, 
report on failures, and find test suite problems.
   - :package: [JS Bundle 
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save 
yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>




> Harden JMXBuilder configuration
> -------------------------------
>
>                 Key: GROOVY-12348
>                 URL: https://issues.apache.org/jira/browse/GROOVY-12348
>             Project: Groovy
>          Issue Type: Improvement
>            Reporter: Paul King
>            Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to