paulk-asert commented on PR #2877: URL: https://github.com/apache/groovy/pull/2877#issuecomment-5556932467
Looking good with some minor aspects: * Minor merge conflict in `ErrorStrategyTest` to pass new lintGate * A closed string with an illegal escape is now misreported. x = "C:\Users\me" gives "Unclosed string literal", where master gave the unhelpful but not wrong "Unexpected character". I don't see this as a blocker but would be nice to fix if possible. An AI assessment proposes: _a scan-ahead in `AbstractLexer.unexpectedCharacterMessage` to report an illegal escape instead_. * AI assessment but I agree we probably just don't need to make the claim: _The adoc and javadoc claim val is "preferred over final in Groovy 6". The spec does not say that anywhere else, and val is behind a system property (default on). Suggest dropping the "preferred" clause._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
