paulk-asert opened a new pull request, #2899: URL: https://github.com/apache/groovy/pull/2899
…stantiating The Metal look-and-feel 'theme' attribute treated an unrecognized string as a class name and did Class.forName(name).getConstructor().newInstance() -- so it resolved, initialized and instantiated an arbitrary class named by the theme value before finding out whether it was even a MetalTheme (the cast failed only afterwards). It also resolved via this class's loader, so an application- or @Grab-supplied theme class was not found. Resolve without initializing via the thread context classloader (falling back to this class's loader when none is set), confirm the class is a MetalTheme before constructing it, and throw IllegalArgumentException otherwise. A non-theme class is now never initialized or constructed, and custom or @Grab-supplied theme classes resolve. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
