[ 
https://issues.apache.org/jira/browse/GROOVY-12391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18113260#comment-18113260
 ] 

ASF GitHub Bot commented on GROOVY-12391:
-----------------------------------------

codecov-commenter commented on PR #2913:
URL: https://github.com/apache/groovy/pull/2913#issuecomment-5600189658

   ## 
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2913?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 71.1936%. Comparing base 
([`17b99a8`](https://app.codecov.io/gh/apache/groovy/commit/17b99a8c6c942b207257090e7ce795b34f58d8b0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
 to head 
([`fcb20d4`](https://app.codecov.io/gh/apache/groovy/commit/fcb20d42888e636066288b13ece6a9e96baea30b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   [![Impacted file tree 
graph](https://app.codecov.io/gh/apache/groovy/pull/2913/graphs/tree.svg?width=650&height=150&src=pr&token=1r45138NfQ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)](https://app.codecov.io/gh/apache/groovy/pull/2913?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   ```diff
   @@                Coverage Diff                 @@
   ##               master      #2913        +/-   ##
   ==================================================
   - Coverage     71.1943%   71.1936%   -0.0007%     
   + Complexity      37632      37630         -2     
   ==================================================
     Files            1581       1581                
     Lines          136251     136251                
     Branches        25311      25311                
   ==================================================
   - Hits            97003      97002         -1     
     Misses          30511      30511                
   - Partials         8737       8738         +1     
   ```
   [see 7 files with indirect coverage 
changes](https://app.codecov.io/gh/apache/groovy/pull/2913/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test 
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, 
report on failures, and find test suite problems.
   - :package: [JS Bundle 
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save 
yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>




> grooid jar: java.beans.Transient is rewritten to a class openbeans never had
> ----------------------------------------------------------------------------
>
>                 Key: GROOVY-12391
>                 URL: https://issues.apache.org/jira/browse/GROOVY-12391
>             Project: Groovy
>          Issue Type: Improvement
>            Reporter: Paul King
>            Assignee: Paul King
>            Priority: Major
>
> Involves: the jarjar rule maps all of java.beans.**, so the Verifier's 
> reference to java.beans.Transient becomes groovyjarjaropenbeans.Transient, 
> which does not exist, and the grooid jar cannot compile anything. Fix is 
> either excluding Transient from the mapping or adding that one annotation 
> class to the repackaged set.
> Impact on normal usage: none for the regular jars. It affects only grooid 
> consumers, and it means the published grooid artifact has been unusable as a 
> compiler since the reference was introduced, so it is also evidence nobody is 
> using it.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to