[
https://issues.apache.org/jira/browse/GROOVY-12388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18113295#comment-18113295
]
ASF GitHub Bot commented on GROOVY-12388:
-----------------------------------------
testlens-app[bot] commented on PR #2910:
URL: https://github.com/apache/groovy/pull/2910#issuecomment-5601531197
## ✅ All tests passed ✅
🏷️ Commit: e5cc553e6ef6951338fe68d608a0e97a27ee51e6
▶️ Tests: 116929 executed
⚪️ Checks: 33/33 completed
---
_Learn more about TestLens at
[testlens.app/docs](https://testlens.app/docs/features/pr-comment/)._
> DgmConverter: avoid MethodType constants in the adapter initialisers
> --------------------------------------------------------------------
>
> Key: GROOVY-12388
> URL: https://issues.apache.org/jira/browse/GROOVY-12388
> Project: Groovy
> Issue Type: Improvement
> Reporter: Paul King
> Assignee: Paul King
> Priority: Major
>
> Involves: the generated dgm$N classes load their target handle with an ldc
> MethodType, which D8 accepts only from API 28. Emitting a
> MethodType.methodType(Class, Class[]) call instead brings the floor back to
> API 26, where indy starts.
> Impact on normal usage: slightly larger adapter bytecode and a method call
> instead of a constant-pool resolution in each adapter's static initialiser,
> both negligible. The value is small too: Android 8 and 8.1 devices are around
> one percent of the installed base, so this is the one I would skip.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
