[
https://issues.apache.org/jira/browse/GROOVY-12389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18113232#comment-18113232
] ASF GitHub Bot commented on GROOVY-12389: ----------------------------------------- codecov-commenter commented on PR #2911: URL: https://github.com/apache/groovy/pull/2911#issuecomment-5599270747 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2911?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `47.36842%` with `10 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 71.1845%. Comparing base ([`17b99a8`](https://app.codecov.io/gh/apache/groovy/commit/17b99a8c6c942b207257090e7ce795b34f58d8b0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`9a91b31`](https://app.codecov.io/gh/apache/groovy/commit/9a91b314518d1a7178f587744a80d5bc8834577a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2911?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...in/java/org/codehaus/groovy/vmplugin/v8/Java8.java](https://app.codecov.io/gh/apache/groovy/pull/2911?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fvmplugin%2Fv8%2FJava8.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3ZtcGx1Z2luL3Y4L0phdmE4LmphdmE=) | 47.3684% | [2 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2911?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2911?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2911 +/- ## ================================================== - Coverage 71.1943% 71.1845% -0.0098% + Complexity 37632 37629 -3 ================================================== Files 1581 1581 Lines 136251 136260 +9 Branches 25311 25316 +5 ================================================== - Hits 97003 96996 -7 - Misses 30511 30517 +6 - Partials 8737 8747 +10 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2911?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...in/java/org/codehaus/groovy/vmplugin/v8/Java8.java](https://app.codecov.io/gh/apache/groovy/pull/2911?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fvmplugin%2Fv8%2FJava8.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3ZtcGx1Z2luL3Y4L0phdmE4LmphdmE=) | `77.5623% <47.3684%> (-2.2672%)` | :arrow_down: | ... and [7 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2911/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > Java8 plugin: skip type-use annotations when the reflection API lacks > AnnotatedType > ----------------------------------------------------------------------------------- > > Key: GROOVY-12389 > URL: https://issues.apache.org/jira/browse/GROOVY-12389 > Project: Groovy > Issue Type: Improvement > Reporter: Paul King > Assignee: Paul King > Priority: Major > > Involves: a TYPE_ANNOTATIONS flag and guards at the seven call sites that > read annotated types while building ClassNodes from reflection. Same > deprecation caveat as item 2. > Impact on normal usage: none on a JVM. Where the API is absent, type-use > annotations on precompiled classes are simply not seen, which is the only > possible behaviour there. -- This message was sent by Atlassian Jira (v8.20.10#820010)
