[
https://issues.apache.org/jira/browse/GROOVY-12411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18115286#comment-18115286
]
ASF GitHub Bot commented on GROOVY-12411:
-----------------------------------------
testlens-app[bot] commented on PR #2936:
URL: https://github.com/apache/groovy/pull/2936#issuecomment-5669227681
## 🚨 TestLens detected 2 failed tests 🚨
Here is what you can do:
1) Inspect the test failures carefully.
2) If you are convinced that some of the tests are flaky, you can mute them
below.
3) Finally, trigger a rerun by checking the rerun checkbox.
### Test Summary
#### [Build and test / lts \(17, windows-latest,
1\)](https://github.com/apache/groovy/actions/runs/34882151420/job/104104380104?pr=2936)
> :groovy-lsp:test
| Test | Runs | Flakiness |
|---|---|--:|
| JdtInspiredTest > renameClassRenamesFileWhenNamesMatch\(\) | ❌ | 0% 🟢
|
| WorkspaceLayoutTest > withInferredFillsEmptySettings\(\) | ❌ | 0% 🟢 |
🏷️ Commit: ce5b6aec95f916fe0b0816eca2fc097174a129e8
▶️ Tests: 88506 executed
🟡 Checks: 17/30 completed
### Test Failures
<details><summary><strong>JdtInspiredTest >
renameClassRenamesFileWhenNamesMatch()</strong> (:groovy-lsp:test in <a
href="https://github.com/apache/groovy/actions/runs/34882151420/job/104104380104?pr=2936";>Build
and test / lts (17, windows-latest, 1)</a>)</summary>
```
java.nio.file.InvalidPathException: Illegal char <:> at index 2:
/d:/a/groovy/groovy/subprojects/groovy-lsp/Hello.groovy
at
java.base/sun.nio.fs.WindowsPathParser.normalize(WindowsPathParser.java:182)
at
java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:153)
at
java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:77)
at java.base/sun.nio.fs.WindowsPath.parse(WindowsPath.java:92)
at
java.base/sun.nio.fs.WindowsFileSystem.getPath(WindowsFileSystem.java:232)
at java.base/java.nio.file.Path.of(Path.java:147)
at
org.apache.groovy.lsp.internal.feature.RenameService.addFileRename(RenameService.java:121)
at
org.apache.groovy.lsp.internal.feature.RenameService.rename(RenameService.java:107)
at
org.apache.groovy.lsp.internal.protocol.GroovyTextDocumentService.rename(GroovyTextDocumentService.java:335)
at
org.apache.groovy.lsp.internal.feature.JdtInspiredTest.renameClassRenamesFileWhenNamesMatch(JdtInspiredTest.groovy:120)
```
</details>
<details><summary><strong>WorkspaceLayoutTest >
withInferredFillsEmptySettings()</strong> (:groovy-lsp:test in <a
href="https://github.com/apache/groovy/actions/runs/34882151420/job/104104380104?pr=2936";>Build
and test / lts (17, windows-latest, 1)</a>)</summary>
```
Assertion failed:
assert inferred.sourcePaths.contains('src/main/groovy')
| | |
| | false
| ['src\\main\\groovy']
org.apache.groovy.lsp.internal.compile.CompilerSettings@46a8c2b4
at
org.codehaus.groovy.runtime.InvokerHelper.createAssertError(InvokerHelper.java:409)
at
org.apache.groovy.lsp.internal.compile.WorkspaceLayoutTest.withInferredFillsEmptySettings(WorkspaceLayoutTest.groovy:74)
```
</details>
### Rerun Controls
> [!NOTE]
> Checks are currently running using the configuration below.
Select tests to mute in this pull request:
🔲 JdtInspiredTest > renameClassRenamesFileWhenNamesMatch\(\) <!
> Add a first-party Language Server Protocol implementation (groovy-lsp)
> ----------------------------------------------------------------------
>
> Key: GROOVY-12411
> URL: https://issues.apache.org/jira/browse/GROOVY-12411
> Project: Groovy
> Issue Type: Improvement
> Reporter: Daniel Sun
> Priority: Major
>
> Ship an optional first-party language server so editors can offer Groovy
> completion, navigation, diagnostics, and refactorings against the in-tree
> compiler rather than a community fork.
> h3. Why
> Community servers ({{groovy-language-server}}, {{gvy}}/{{gls}}) lag language
> changes. A module in this repository compiles with the same
> {{CompilationUnit}} the rest of Groovy uses, so parser and type-system work
> land in the IDE automatically.
> h3. What to ship
> * New optional subproject {{groovy-lsp}} (not part of {{groovy-all}})
> * {{groovylsp}} / {{groovylsp.bat}} launchers (stdio JSON-RPC; optional
> {{--socket}})
> * LSP 3.18 over Eclipse LSP4J 1.0; unknown 3.19 fields ignored
> * Compile open buffers through {{SEMANTIC_ANALYSIS}} (no class generation)
> * Identifier name spans on {{AnnotatedNode}} so rename/highlight select the
> name, not the whole declaration (same 1-based code-point columns as
> GROOVY-12085)
> h3. Language features (advertise only what is implemented)
> * Incremental sync, push/pull diagnostics
> * Completion (keywords, snippets, members, workspace types with auto-import,
> GDK with a prefix) and {{completionItem/resolve}}
> * Hover, signature help, document highlight
> * Definition, type definition, implementation, declaration, references (by
> declaration identity)
> * Prepare-rename / rename (rename the file when the class name matches the
> file stem)
> * Document and workspace symbols, folding, selection range, semantic tokens,
> inlay hints
> * Organize imports (star, static, alias); unused-import hints
> * Code actions: add import, implement abstracts, insert inferred field type,
> add package from path, create missing class stub, generate accessors /
> {{toString}} / {{equals}}/{{hashCode}} / constructor, add {{@Override}}
> * Call hierarchy and type hierarchy
> * Reference-count code lenses
> h3. Safety and classpath
> * {{@Grab}} and {{@ASTTest}} off unless the client sets {{grapeEnabled}} /
> {{astTestEnabled}}
> * Diagnostics scoped to the owning source unit (shared {{ErrorCollector}})
> * No Gradle or Maven Tooling API; the client supplies {{classpath}} /
> {{sourcePaths}}. If those are empty, fall back to {{src/main/groovy}} (and
> friends) and jars under {{lib}} / {{libs}}
> * Unchanged inputs skip recompilation; {{GroovyClassLoader}} is reused and
> closed on shutdown
> h3. Out of scope
> * Debugger (DAP)
> * Test runner
> * Invoking Gradle or Maven to resolve the project
> h3. How to run
> {code}
> groovylsp
> {code}
> Optional flags: {{\-\-stdio}} (default), {{\-\-socket port}}, {{\-\-help}},
> {{\-\-version}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
