[
https://issues.apache.org/jira/browse/GROOVY-12450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18126775#comment-18126775
]
ASF GitHub Bot commented on GROOVY-12450:
-----------------------------------------
codecov-commenter commented on PR #2979:
URL: https://github.com/apache/groovy/pull/2979#issuecomment-6148322808
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2979?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
:x: Patch coverage is `80.00000%` with `2 lines` in your changes missing
coverage. Please review.
:white_check_mark: Project coverage is 72.2623%. Comparing base
([`d163cd0`](https://app.codecov.io/gh/apache/groovy/commit/d163cd0ceb9cc4fddb283fad8a7099d646d04f46?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
to head
([`c2f78d8`](https://app.codecov.io/gh/apache/groovy/commit/c2f78d83cb34ff64734dfa368022056d72126d92?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing
lines](https://app.codecov.io/gh/apache/groovy/pull/2979?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Patch % | Lines |
|---|---|---|
|
[src/main/java/groovy/time/Timed.java](https://app.codecov.io/gh/apache/groovy/pull/2979?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fgroovy%2Ftime%2FTimed.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9ncm9vdnkvdGltZS9UaW1lZC5qYXZh)
| 80.0000% | [1 Missing and 1 partial :warning:
](https://app.codecov.io/gh/apache/groovy/pull/2979?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/groovy/pull/2979?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #2979 +/- ##
==================================================
+ Coverage 72.2610% 72.2623% +0.0012%
- Complexity 40505 40510 +5
==================================================
Files 1643 1643
Lines 142554 142564 +10
Branches 26769 26769
==================================================
+ Hits 103011 103020 +9
- Misses 30085 30086 +1
Partials 9458 9458
```
| [Files with missing
lines](https://app.codecov.io/gh/apache/groovy/pull/2979?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Coverage Δ | |
|---|---|---|
|
[src/main/java/groovy/time/Timed.java](https://app.codecov.io/gh/apache/groovy/pull/2979?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fgroovy%2Ftime%2FTimed.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9ncm9vdnkvdGltZS9UaW1lZC5qYXZh)
| `84.6154% <80.0000%> (-15.3846%)` | :arrow_down: |
... and [11 files with indirect coverage
changes](https://app.codecov.io/gh/apache/groovy/pull/2979/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests,
report on failures, and find test suite problems.
- :package: [JS Bundle
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save
yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
> Provide some of Groovy's enhanced record features (getAt, toMap, toList,
> size) for groovy.time.Timed
> ----------------------------------------------------------------------------------------------------
>
> Key: GROOVY-12450
> URL: https://issues.apache.org/jira/browse/GROOVY-12450
> Project: Groovy
> Issue Type: Improvement
> Reporter: Paul King
> Assignee: Paul King
> Priority: Major
>
> This works:
> {code:groovy}
> def (result: r, duration: d) = System.timed {
> new Date()
> }
> println r
> println d.toNanos()
> {code}
> But the shorter variant fails:
> {code:groovy}
> def (r, d) = System.timed {
> new Date()
> }
> println r
> println d
> {code}
> with:
> {noformat}
> MissingMethodException: No signature of method: getAt for class:
> groovy.time.Timed is applicable for argument types: (Integer) values: [0]
> {noformat}
> We could make Timed a Groovy record instead of a Java record, or provide
> getAt(int) and any other methods we may want, e.g. toMap, etc.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
