codeconsole commented on code in PR #2949:
URL: https://github.com/apache/groovy/pull/2949#discussion_r4308544702
##########
subprojects/groovy-yaml/build.gradle:
##########
@@ -22,12 +22,12 @@ plugins {
dependencies {
api project(':') // YamlBuilder extends GroovyObjectSupport...
- implementation
"com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:${versions.jackson}"
- implementation
"com.fasterxml.jackson.core:jackson-databind:${versions.jackson}"
- implementation
"com.fasterxml.jackson.datatype:jackson-datatype-jsr310:${versions.jackson}"
+ implementation
"tools.jackson.dataformat:jackson-dataformat-yaml:${versions.jackson3}"
Review Comment:
Keeping Jackson 3's resolution, since this targets 7.0, and documenting it
as a breaking change. It's wider than booleans: Jackson 3.1.6 hard-codes
snakeyaml-engine's `JsonScalarResolver` in `YAMLParser`, so `True`/`FALSE`,
`Null`/`~` and `0x1F`/`017` also become strings, and no feature or
`LoadSettings` schema restores YAML 1.1 resolution. 3702e55 adds
`YamlScalarResolutionTest` pinning the behaviour and a note in the YAML user
guide; the PR description now lists it under breaking changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
