paulk-asert commented on PR #3001: URL: https://github.com/apache/groovy/pull/3001#issuecomment-6313849532
Thanks, the fix is right. Some minor things: - Of the parsing methods, only `parseAs(Class, Reader)` got the check. For bonus points, we should cover `InputStream`, `File` and `Path` overloads. Each repeat the parse-then-convert body, so `parseAs(Node, file)` still fails for example in the same way. Could you route all four through a small private helper and add a test via one of the other overloads? - Also a typo, "alreads", in the asType javadoc - Could you raise a JIRA for the commit message and release tracking? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
