[
https://issues.apache.org/jira/browse/GROOVY-12454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18130833#comment-18130833
]
ASF GitHub Bot commented on GROOVY-12454:
-----------------------------------------
codecov-commenter commented on PR #3013:
URL: https://github.com/apache/groovy/pull/3013#issuecomment-6363355422
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/3013?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
:x: Patch coverage is `95.38462%` with `3 lines` in your changes missing
coverage. Please review.
:white_check_mark: Project coverage is 72.4518%. Comparing base
([`fa53afa`](https://app.codecov.io/gh/apache/groovy/commit/fa53afab4ff811b7ed93560300cd626d0374842e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
to head
([`b148576`](https://app.codecov.io/gh/apache/groovy/commit/b1485762e5c26bc598c545113289193eacd33cd6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing
lines](https://app.codecov.io/gh/apache/groovy/pull/3013?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Patch % | Lines |
|---|---|---|
|
[...rm/sc/transformers/ConstructorCallTransformer.java](https://app.codecov.io/gh/apache/groovy/pull/3013?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2Fsc%2Ftransformers%2FConstructorCallTransformer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9zYy90cmFuc2Zvcm1lcnMvQ29uc3RydWN0b3JDYWxsVHJhbnNmb3JtZXIuamF2YQ==)
| 94.9152% | [1 Missing and 2 partials :warning:
](https://app.codecov.io/gh/apache/groovy/pull/3013?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/groovy/pull/3013?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #3013 +/- ##
==================================================
+ Coverage 72.4452% 72.4518% +0.0066%
- Complexity 40687 40689 +2
==================================================
Files 1644 1644
Lines 142897 142946 +49
Branches 26877 26882 +5
==================================================
+ Hits 103522 103567 +45
- Misses 29820 29826 +6
+ Partials 9555 9553 -2
```
| [Files with missing
lines](https://app.codecov.io/gh/apache/groovy/pull/3013?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Coverage Δ | |
|---|---|---|
|
[...roovy/transform/stc/StaticTypeCheckingVisitor.java](https://app.codecov.io/gh/apache/groovy/pull/3013?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2Fstc%2FStaticTypeCheckingVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9zdGMvU3RhdGljVHlwZUNoZWNraW5nVmlzaXRvci5qYXZh)
| `87.0998% <100.0000%> (+0.0232%)` | :arrow_up: |
|
[...rm/sc/transformers/ConstructorCallTransformer.java](https://app.codecov.io/gh/apache/groovy/pull/3013?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2Fsc%2Ftransformers%2FConstructorCallTransformer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9zYy90cmFuc2Zvcm1lcnMvQ29uc3RydWN0b3JDYWxsVHJhbnNmb3JtZXIuamF2YQ==)
| `95.1220% <94.9152%> (+3.2301%)` | :arrow_up: |
... and [9 files with indirect coverage
changes](https://app.codecov.io/gh/apache/groovy/pull/3013/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests,
report on failures, and find test suite problems.
- :package: [JS Bundle
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save
yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
> "Target constructor for constructor call expression hasn't been set" when
> using map-constructor-call with method-returned map under static compilation
> ------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: GROOVY-12454
> URL: https://issues.apache.org/jira/browse/GROOVY-12454
> Project: Groovy
> Issue Type: Bug
> Affects Versions: 2.5.23, 3.0.25, 5.0.3, 4.0.33, 5.1.3, 6.0.0
> Reporter: Björn Kautler
> Priority: Major
>
> Given the snippet
> {code:groovy}
> class Person2 {
> def name
> def age
> }
> def <T> T record(T value) {
> value
> }
> Map recordMap(Map value) {
> value
> }
> @groovy.transform.CompileStatic
> def foo() {
> [
> new Person2(record([name: 'fred', age: 25])),
> new Person2([name: 'fred', age: 25]),
> new Person2(recordMap([name: 'fred', age: 25]))
> ]
> }
> foo() {code}
>
> With the {{CompileStatic}} line commented out, all versions mentioned as
> affected compile fine and run fine, returning a list with three identical
> person instances with the properties set.
> With the snippet as given, none of the versions can compile the snippet due
> to the first and last constructor lines.
> Except of 3.0.25 all versions tell for both lines "Target constructor for
> constructor call expression hasn't been set".
> 3.0.25 shows the same for the first one, and "Cannot find matching method
> Person2#<init>(java.util.Map). Please check if the declared type is correct
> and if the method exists." for the last one.
> With {{TypeChecked}} instead of {{CompileStatic}} it also works fine in all
> versions except 3.0.25. 3.0.25 with only type-checke can compile the first
> line but still has the same error for the last line.z
>
> So it seems the SC does not properly use the "map-constructor-call" semantics
> if a normal or generic method call returned type {{{}Map{}}}, plus 3.0.25
> having some additional problem.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
