[
https://issues.apache.org/jira/browse/GROOVY-12490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Scott Murphy Heiberg updated GROOVY-12490:
------------------------------------------
Description:
GROOVY-12240 made enum constants without arguments call the {{(String,int)}}
constructor directly. Every constant with arguments still goes through the
synthetic {{$INIT(Object[])}} helper, whose body is a spread {{this(*para)}}:
{{MetaClassImpl}} selects the constructor by reflecting over the declared
constructors. {{@CompileStatic}} does not change that, since {{$INIT}}'s own
body stays dynamic.
As a result, an ordinary enum fails to initialize in a GraalVM native image
built without reflection metadata for it:
{code:groovy}
enum AccessModifier {
PRIVATE('private'), PROTECTED('protected'), PUBLIC('public')
final String keyword
AccessModifier(String keyword) { this.keyword = keyword }
}
{code}
As written, the enum fails at the dynamic call to {{$INIT}} itself:
{noformat}
groovy.lang.MissingMethodException: No signature of static method: $INIT for
class: AccessModifier is applicable for argument types: (String, Integer,
String)
{noformat}
With {{@CompileStatic}} on the enum, {{$INIT}} is called with {{invokestatic}},
and the constructor selection in its body fails instead:
{noformat}
groovy.lang.GroovyRuntimeException: Could not find matching constructor for:
AccessModifier(String, Integer, String)
{noformat}
Proposed fix: call the constructor directly when the compiler can prove what
the runtime would do: every argument is a literal, exactly one non-synthetic
constructor has the arity and none could take the arguments as varargs, and
each literal reaches its parameter unchanged ({{Boolean}} parameters excluded).
Everything else keeps {{$INIT}}, and the decision stays per enum, as in
GROOVY-12240.
PR: https://github.com/apache/groovy/pull/3024
was:
GROOVY-12240 made enum constants without arguments call the {{(String,int)}}
constructor directly. Every constant with arguments still goes through the
synthetic {{$INIT(Object[])}} helper, whose body is a spread {{this(*para)}}:
{{MetaClassImpl}} selects the constructor by reflecting over the declared
constructors. {{@CompileStatic}} does not change that, since {{$INIT}}'s own
body stays dynamic.
As a result, an ordinary enum fails to initialize in a GraalVM native image
built without reflection metadata for it:
{code:groovy}
enum AccessModifier {
PRIVATE('private'), PROTECTED('protected'), PUBLIC('public')
final String keyword
AccessModifier(String keyword) { this.keyword = keyword }
}
{code}
{noformat}
groovy.lang.GroovyRuntimeException: Could not find matching constructor for:
AccessModifier(String, Integer, String)
{noformat}
Proposed fix: call the constructor directly when the compiler can prove what
the runtime would do: every argument is a literal, exactly one non-synthetic
constructor has the arity and none could take the arguments as varargs, and
each literal reaches its parameter unchanged ({{Boolean}} parameters excluded).
Everything else keeps {{$INIT}}, and the decision stays per enum, as in
GROOVY-12240.
PR: https://github.com/apache/groovy/pull/3024
> Enum constants with literal arguments still select their constructor
> reflectively through $INIT
> -----------------------------------------------------------------------------------------------
>
> Key: GROOVY-12490
> URL: https://issues.apache.org/jira/browse/GROOVY-12490
> Project: Groovy
> Issue Type: Improvement
> Components: Compiler
> Affects Versions: 6.0.0
> Reporter: Scott Murphy Heiberg
> Priority: Major
>
> GROOVY-12240 made enum constants without arguments call the {{(String,int)}}
> constructor directly. Every constant with arguments still goes through the
> synthetic {{$INIT(Object[])}} helper, whose body is a spread {{this(*para)}}:
> {{MetaClassImpl}} selects the constructor by reflecting over the declared
> constructors. {{@CompileStatic}} does not change that, since {{$INIT}}'s own
> body stays dynamic.
> As a result, an ordinary enum fails to initialize in a GraalVM native image
> built without reflection metadata for it:
> {code:groovy}
> enum AccessModifier {
> PRIVATE('private'), PROTECTED('protected'), PUBLIC('public')
> final String keyword
> AccessModifier(String keyword) { this.keyword = keyword }
> }
> {code}
> As written, the enum fails at the dynamic call to {{$INIT}} itself:
> {noformat}
> groovy.lang.MissingMethodException: No signature of static method: $INIT for
> class: AccessModifier is applicable for argument types: (String, Integer,
> String)
> {noformat}
> With {{@CompileStatic}} on the enum, {{$INIT}} is called with
> {{invokestatic}}, and the constructor selection in its body fails instead:
> {noformat}
> groovy.lang.GroovyRuntimeException: Could not find matching constructor for:
> AccessModifier(String, Integer, String)
> {noformat}
> Proposed fix: call the constructor directly when the compiler can prove what
> the runtime would do: every argument is a literal, exactly one non-synthetic
> constructor has the arity and none could take the arguments as varargs, and
> each literal reaches its parameter unchanged ({{Boolean}} parameters
> excluded). Everything else keeps {{$INIT}}, and the decision stays per enum,
> as in GROOVY-12240.
> PR: https://github.com/apache/groovy/pull/3024
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
