paulk-asert commented on PR #3014: URL: https://github.com/apache/groovy/pull/3014#issuecomment-6403054528
Thanks Daniel. 1. The guard only ever fires for record components. `PropertyNode.getGetterName()` is null unless set explicitly, and the only `setGetterName` callers in the codebase are `RecordTypeASTTransformation` and `RecordBaseASTStubber`, both setting it to the component name. No other AST shape sets an explicit getter name, so ordinary bean resolution is untouched. 2. Property-style reads (`flags.isActive`, `person.getName`, including emulated records) and map-style construction go through the property path rather than this accessor lookup, and they already worked before the fix (checked on 6.0.0, which has the bug). The hunk only affects the method-call form. 3. Agreed, precompiled records were never affected since the accessor is a real method on the class. I'll leave the tests as they are, and add a javadoc sentence to Groovy12452 before merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
