[
https://issues.apache.org/jira/browse/GROOVY-12525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18133672#comment-18133672
]
ASF GitHub Bot commented on GROOVY-12525:
-----------------------------------------
codecov-commenter commented on PR #3066:
URL: https://github.com/apache/groovy/pull/3066#issuecomment-6474288131
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/3066?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
:x: Patch coverage is `65.71429%` with `12 lines` in your changes missing
coverage. Please review.
:white_check_mark: Project coverage is 73.6123%. Comparing base
([`cfd9b2f`](https://app.codecov.io/gh/apache/groovy/commit/cfd9b2f0222a8e1a74473f7c5b2cb45b5bdd3b5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
to head
([`3cf582b`](https://app.codecov.io/gh/apache/groovy/commit/3cf582b5a389c796972a52145bae6ba1dac61d0a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing
lines](https://app.codecov.io/gh/apache/groovy/pull/3066?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Patch % | Lines |
|---|---|---|
|
[...roovy/transform/stc/StaticTypeCheckingVisitor.java](https://app.codecov.io/gh/apache/groovy/pull/3066?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2Fstc%2FStaticTypeCheckingVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9zdGMvU3RhdGljVHlwZUNoZWNraW5nVmlzaXRvci5qYXZh)
| 65.7143% | [6 Missing and 6 partials :warning:
](https://app.codecov.io/gh/apache/groovy/pull/3066?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/groovy/pull/3066?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #3066 +/- ##
==================================================
+ Coverage 73.6047% 73.6123% +0.0075%
- Complexity 42348 42378 +30
==================================================
Files 1657 1657
Lines 145708 145742 +34
Branches 27498 27520 +22
==================================================
+ Hits 107248 107284 +36
+ Misses 28479 28475 -4
- Partials 9981 9983 +2
```
| [Files with missing
lines](https://app.codecov.io/gh/apache/groovy/pull/3066?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Coverage Δ | |
|---|---|---|
|
[...roovy/transform/stc/StaticTypeCheckingVisitor.java](https://app.codecov.io/gh/apache/groovy/pull/3066?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2Fstc%2FStaticTypeCheckingVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9zdGMvU3RhdGljVHlwZUNoZWNraW5nVmlzaXRvci5qYXZh)
| `87.2932% <65.7143%> (-0.1779%)` | :arrow_down: |
... and [9 files with indirect coverage
changes](https://app.codecov.io/gh/apache/groovy/pull/3066/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests,
report on failures, and find test suite problems.
- :package: [JS Bundle
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save
yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
> STC accepts a call to an isX() or getX() accessor that the property does not
> generate
> -------------------------------------------------------------------------------------
>
> Key: GROOVY-12525
> URL: https://issues.apache.org/jira/browse/GROOVY-12525
> Project: Groovy
> Issue Type: Bug
> Components: Static Type Checker
> Affects Versions: 6.0.0
> Reporter: Scott Murphy Heiberg
> Assignee: Daniel Sun
> Priority: Major
>
> The type checker accepts a call to an accessor method that a property would
> generate, also when the property does not generate it, and the call then
> fails at run time in every mode:
> {code:groovy}
> @groovy.transform.TypeChecked
> class Box {
> boolean flag = true
> boolean getFlag() { flag } // with an explicit getFlag(), no isFlag() is
> generated
> }
> @groovy.transform.TypeChecked
> class C {
> boolean test(Box b) { b.isFlag() }
> }
> new C().test(new Box()) // MissingMethodException: No signature of method:
> isFlag for class: Box
> {code}
> Dynamic Groovy throws the same exception. Under {{@CompileStatic}} the call
> compiles to {{Box.isFlag()}} and fails with {{NoSuchMethodError: 'boolean
> Box.isFlag()'}}. The same happens for {{b.getFlag()}} when {{Box}} declares
> {{isFlag()}} instead, and for {{b.isFlag()}} on a {{Boolean flag}} property,
> which only gets {{getFlag()}}. Without an explicit accessor, a {{boolean}}
> property gets both, and the call works. Seen in 4.0.33, 5.0.8, 6.0.0 and
> master.
> Expected: "Cannot find matching method Box#isFlag()".
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
