[
https://issues.apache.org/jira/browse/GROOVY-12315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18133682#comment-18133682
] ASF GitHub Bot commented on GROOVY-12315: ----------------------------------------- codecov-commenter commented on PR #3069: URL: https://github.com/apache/groovy/pull/3069#issuecomment-6474792848 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/3069?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `62.85714%` with `65 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 73.5975%. Comparing base ([`cfd9b2f`](https://app.codecov.io/gh/apache/groovy/commit/cfd9b2f0222a8e1a74473f7c5b2cb45b5bdd3b5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`515f25a`](https://app.codecov.io/gh/apache/groovy/commit/515f25a2a911a3506ec6611529706b65de6fca4f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 2 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/3069?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...roovy/transform/stc/StaticTypeCheckingVisitor.java](https://app.codecov.io/gh/apache/groovy/pull/3069?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2Fstc%2FStaticTypeCheckingVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9zdGMvU3RhdGljVHlwZUNoZWNraW5nVmlzaXRvci5qYXZh) | 62.8571% | [29 Missing and 36 partials :warning: ](https://app.codecov.io/gh/apache/groovy/pull/3069?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/3069?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #3069 +/- ## ================================================== - Coverage 73.6047% 73.5975% -0.0073% - Complexity 42348 42427 +79 ================================================== Files 1657 1657 Lines 145708 145880 +172 Branches 27498 27569 +71 ================================================== + Hits 107248 107364 +116 - Misses 28479 28501 +22 - Partials 9981 10015 +34 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/3069?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...roovy/transform/stc/StaticTypeCheckingVisitor.java](https://app.codecov.io/gh/apache/groovy/pull/3069?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2Fstc%2FStaticTypeCheckingVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9zdGMvU3RhdGljVHlwZUNoZWNraW5nVmlzaXRvci5qYXZh) | `86.5033% <62.8571%> (-0.9677%)` | :arrow_down: | ... and [10 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/3069/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > Type for final field should be known by flow-typing > --------------------------------------------------- > > Key: GROOVY-12315 > URL: https://issues.apache.org/jira/browse/GROOVY-12315 > Project: Groovy > Issue Type: Bug > Affects Versions: 6.0.0-alpha-1, 5.0.3, 4.0.31 > Reporter: Björn Kautler > Assignee: Daniel Sun > Priority: Major > > This does not compile, while the type should be clear as the field is final: > {code:java} > @groovy.transform.CompileStatic > class Foo { > final bar = '' > def foo() { > println(bar.length()) > } > } > new Foo().foo() {code} > With a local variable it works even without {{{}final{}}}. -- This message was sent by Atlassian Jira (v10.3.26#10030026)
