jdaugherty opened a new pull request, #3082:
URL: https://github.com/apache/groovy/pull/3082

   A reference to the log field added by @Log and friends was guarded only
   while unbound. With the superclass read from bytecode, it was bound to
   the superclass's private log field instead and the guard was dropped.
   
   `bugs.Groovy12553` compiles the classes once together and once with one of 
them compiled against the others already compiled, as an incremental build 
does, and compares the class files. It fails without the fix.
   
   - Jira: [GROOVY-12553](https://issues.apache.org/jira/browse/GROOVY-12553)
   - Reproducer, with `groovyc` and a Gradle incremental build: 
https://github.com/jdaugherty/groovy-log-guard-precompiled-superclass
   - Backport to `GROOVY_5_1_X`: 
https://github.com/jdaugherty/groovy/commit/0239ac38004340f2ee7a6537d1621c77b2f351b7,
 on the branch 
[`GROOVY-12553-5_1_X`](https://github.com/jdaugherty/groovy/tree/GROOVY-12553-5_1_X).
   
   It reproduces on 4.0.33, 5.1.3 and master. Could this be backported to 5.x 
once it is merged?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to