jdaugherty commented on PR #3076: URL: https://github.com/apache/groovy/pull/3076#issuecomment-6501773440
I backported this to `GROOVY_5_1_X`: https://github.com/jdaugherty/groovy/commit/334e614a44e5cc78c499cc778b3a02736ec2a24d, on the branch [`GROOVY-10932-5_1_X`](https://github.com/jdaugherty/groovy/tree/GROOVY-10932-5_1_X). The change is the same, written for Java 11: a cast replaces the pattern-matching `instanceof`. `Groovy10932` passes on 5.1.x, and the full 5.1.x core test suite passes with this and #3077 applied. The last commit on the branch only adds a README that explains the problem. We tried it, together with #3077, on a large Grails 8 application on Groovy 5.1.3. The `NoClassDefFoundError` for trait helpers during incremental compilation is gone, and implementers of pre-compiled traits now compile to the same binary API as in a full build. Could this be backported to 5.x once it is merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
