[
https://issues.apache.org/jira/browse/GROOVY-12606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18135637#comment-18135637
]
ASF GitHub Bot commented on GROOVY-12606:
-----------------------------------------
testlens-app[bot] commented on PR #3133:
URL: https://github.com/apache/groovy/pull/3133#issuecomment-6539962856
## 🚨 TestLens detected 1 failed test 🚨
### Test Summary
> [!TIP]
> Inspect all details with the [TestLens
CLI](https://testlens.app/docs/features/cli): `testlens pr 3133`
#### [Build and test / lts \(17,
ubuntu-latest\)](https://github.com/apache/groovy/actions/runs/41173971677/job/124457583287?pr=3133)
> :test
| Test | Runs | Flakiness |
|---|---|--:|
| ParallelCollectionTest > testEachParallelRunsConcurrently\(\) | ❌ |
1% 🟡 |
🏷️ Commit: 1ef5dabdfbdaad8e6ef3ed5b09b8ec6531ddd490
▶️ Tests: 49028 executed
🟡 Checks: 11/24 completed
### Test Failures
<details><summary><strong>ParallelCollectionTest >
testEachParallelRunsConcurrently()</strong> (:test in <a
href="https://github.com/apache/groovy/actions/runs/41173971677/job/124457583287?pr=3133";>Build
and test / lts (17, ubuntu-latest)</a>)</summary>
```
java.lang.reflect.UndeclaredThrowableException
at
java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native
Method)
at
java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
at
java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at
java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)
at
java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:481)
at
java.base/java.util.concurrent.ForkJoinTask.getThrowableException(ForkJoinTask.java:562)
at
java.base/java.util.concurrent.ForkJoinTask.reportException(ForkJoinTask.java:591)
at
java.base/java.util.concurrent.ForkJoinTask.join(ForkJoinTask.java:672)
at
org.codehaus.groovy.runtime.ParallelCollectionExtensions.lambda$eachParallel$1(ParallelCollectionExtensions.java:118)
at
org.codehaus.groovy.runtime.ParallelCollectionExtensions.withPool(ParallelCollectionExtensions.java:405)
at
org.codehaus.groovy.runtime.ParallelCollectionExtensions.eachParallel(ParallelCollectionExtensions.java:117)
at TestScript109$_run_closure1$_closure2.doCall(TestScript109.groovy:19)
at groovy.lang.Closure.invokeHandle(Closure.java:647)
at groovy.lang.Closure.invokeCached(Closure.java:618)
at groovy.lang.Closure.call(Closure.java:584)
at groovy.lang.Closure.call(Closure.java:543)
at
org.codehaus.groovy.runtime.DefaultGroovyMethods.times(DefaultGroovyMethods.java:17402)
at TestScript109$_run_closure1.doCall(TestScript109.groovy:15)
at groovy.lang.Closure.invokeHandle(Closure.java:647)
at groovy.lang.Closure.invokeCached(Closure.java:618)
at groovy.lang.Closure.call(Closure.java:584)
at
org.codehaus.groovy.runtime.ConvertedClosure.invokeCustom(ConvertedClosure.java:55)
at
org.codehaus.groovy.runtime.ConversionHandler.invoke(ConversionHandler.java:130)
at jdk.proxy2/jdk.proxy2.$Proxy53.apply(Unknown Source)
at groovy.concurrent.AsyncScope.lambda$withScope$0(AsyncScope.java:167)
at
org.apache.groovy.runtime.async.ScopedLocal$Carrier.lambda$call$0(ScopedLocal.java:320)
at
org.apache.groovy.runtime.async.ScopedLocal$ThreadLocalImpl.bind(ScopedLocal.java:428)
at
org.apache.groovy.runtime.async.ScopedLocal$Carrier.lambda$execute$1(ScopedLocal.java:338)
at
org.apache.groovy.runtime.async.ScopedLocal$Carrier.execute(ScopedLocal.java:340)
at
org.apache.groovy.runtime.async.ScopedLocal$Carrier.call(ScopedLocal.java:320)
at
org.apache.groovy.runtime.async.ScopedLocal.where(ScopedLocal.java:220)
at
org.apache.groovy.runtime.async.DefaultAsyncScope.withCurrent(DefaultAsyncScope.java:99)
at groovy.concurrent.AsyncScope.withCurrent(AsyncScope.java:121)
at groovy.concurrent.AsyncScope.withScope(AsyncScope.java:167)
at
groovy.concurrent.ParallelScope.lambda$withPool$1(ParallelScope.java:92)
at
org.apache.groovy.runtime.async.ScopedLocal$Carrier.lambda$call$0(ScopedLocal.java:320)
at
org.apache.groovy.runtime.async.ScopedLocal$ThreadLocalImpl.bind(ScopedLocal.java:428)
at
org.apache.groovy.runtime.async.ScopedLocal$Carrier.lambda$execute$1(ScopedLocal.java:338)
at
org.apache.groovy.runtime.async.ScopedLocal$Carrier.execute(ScopedLocal.java:340)
at
org.apache.groovy.runtime.async.ScopedLocal$Carrier.call(ScopedLocal.java:320)
at
org.apache.groovy.runtime.async.ScopedLocal.where(ScopedLocal.java:220)
at
org.apache.groovy.runtime.async.DefaultPool.withCurrent(DefaultPool.java:262)
at groovy.concurrent.Pool.withCurrent(Pool.java:152)
at groovy.concurrent.ParallelScope.withPool(ParallelScope.java:92)
at TestScript109.run(TestScript109.groovy:13)
at groovy.lang.GroovyShell.evaluate(GroovyShell.java:552)
at groovy.lang.GroovyShell.evaluate(GroovyShell.java:587)
at groovy.lang.GroovyShell.evaluate(GroovyShell.java:571)
at groovy.test.GroovyAssert.assertScript(GroovyAssert.java:107)
at groovy.test.GroovyAssert.assertScript(GroovyAssert.java:97)
at
groovy.concurrent.ParallelCollectionTest.testEachParallelRunsConcurrently(ParallelCollectionTest.groovy:48)
Caused by: java.lang.reflect.UndeclaredThrowableException
at jdk.proxy2/jdk.proxy2.$Proxy61.accept(Unknown Source)
at
java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
at
java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:992)
at
java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
at
java.base/java.util.stream.ForEachOps$ForEachTask.compute(ForEachOps.java:290)
at
java.base/java.util.concurrent.CountedCompleter.exec(CountedCompleter.java:754)
at
java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373)
at
java.base/java.util.concurrent.ForkJoinPool$WorkQueue.helpComplete(ForkJoinPool.java:1234)
at
java.base/java.util.concurrent.ForkJoinPool.helpComplete(ForkJoinPool.java:1926)
at
java.base/java.util.concurrent.ForkJoinTask.awaitDone(ForkJoinTask.java:433)
at
java.base/java.util.concurrent.ForkJoinTask.invoke(ForkJoinTask.java:687)
at
java.base/java.util.stream.ForEachOps$ForEachOp.evaluateParallel(ForEachOps.java:159)
at
java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateParallel(ForEachOps.java:173)
at
java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:233)
at
java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
at
java.base/java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:765)
at
org.codehaus.groovy.runtime.ParallelCollectionExtensions.lambda$eachParallel$0(ParallelCollectionExtensions.java:118)
at
java.base/java.util.concurrent.ForkJoinTask$AdaptedRunnableAction.exec(ForkJoinTask.java:1375)
at
java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373)
at
java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1193)
at
java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1666)
at
java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1633)
at
java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165)
Caused by: java.util.concurrent.TimeoutException
at
java.base/java.util.concurrent.CyclicBarrier.dowait(CyclicBarrier.java:259)
at
java.base/java.util.concurrent.CyclicBarrier.await(CyclicBarrier.java:437)
at
TestScript109$_run_closure1$_closure2$_closure3.doCall(TestScript109.groovy:21)
at groovy.lang.Closure.invokeHandle(Closure.java:647)
at groovy.lang.Closure.invokeCached(Closure.java:618)
at groovy.lang.Closure.call(Closure.java:584)
at
org.codehaus.groovy.runtime.ConvertedClosure.invokeCustom(ConvertedClosure.java:55)
at
org.codehaus.groovy.runtime.ConversionHandler.invoke(ConversionHandler.java:130)
... 23 more
```
</details>
### Rerun Controls
> [!NOTE]
> Checks are currently running using the configuration below.
Select tests to mute in this pull request:
🔲 ParallelCollectionTest > testEachParallelRunsConcurrently\(\) <!
> STC rejects a closure or lambda returning a Closure<R> value where a
> functional interface return type is expected
> -----------------------------------------------------------------------------------------------------------------
>
> Key: GROOVY-12606
> URL: https://issues.apache.org/jira/browse/GROOVY-12606
> Project: Groovy
> Issue Type: Bug
> Affects Versions: 4.0.33, 5.0.8, 6.0.0
> Reporter: Scott Murphy Heiberg
> Priority: Major
>
> {code:groovy}
> import java.util.function.Supplier
> @groovy.transform.CompileStatic // or @TypeChecked
> class C {
> static String take(Supplier<Supplier<String>> s) { s.get().get() }
> static void main(args) {
> Closure<String> c = { 'x' }
> assert take { c } == 'x'
> assert take(() -> c) == 'x'
> }
> }
> {code}
> Actual:
> {noformat}
> [Static type checking] - Cannot return value of type
> groovy.lang.Closure<java.lang.String> for closure expecting
> java.util.function.Supplier<java.lang.String>
> [Static type checking] - Cannot return value of type
> groovy.lang.Closure<java.lang.String> for lambda expecting
> java.util.function.Supplier<java.lang.String>
> {noformat}
> Expected: both calls compile and the returned closure is converted to the
> functional interface, as it is when a Closure value is passed as a Supplier
> argument. A Closure<Integer> should still be rejected.
> The return check for closures and lambdas only accepts subtypes of the
> expected return type and does not consider closure-to-SAM coercion. A
> returned closure literal and a raw Closure are rejected the same way. Under
> static compilation, a lambda also needs its generated method to declare the
> SAM type, so that the returned closure is converted instead of being returned
> as a Closure.
> Seen in 4.0.33, 5.0.8 and 6.0.0.
> PR: https://github.com/apache/groovy/pull/3133
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
