[
https://issues.apache.org/jira/browse/GROOVY-7407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18136053#comment-18136053
]
Jex Jexler commented on GROOVY-7407:
------------------------------------
Note that the Ivy lock strategy (artifact-lock-nio) only protects the Grape
cache files. Concurrent grabs are still not safe, even with an Ivy timeout as
proposed in GROOVY-12640: {{GrapeIvy}} has shared state that is not
synchronized (e.g. {{loadedDeps}}, {{grabRecordsForCurrDependencies}}, and
per-call changes to the shared {{IvySettings}}). So I still recommend wrapping
the engine with one that locks, as Grengine's {{Grengine.Grape.activate()}}
does. Details:
https://github.com/alainstalder/grengine/blob/main/testbed/grapeconcurrency/7407.md
> Compilation not thread safe if Grape / Ivy is used in Groovy scripts
> --------------------------------------------------------------------
>
> Key: GROOVY-7407
> URL: https://issues.apache.org/jira/browse/GROOVY-7407
> Project: Groovy
> Issue Type: Bug
> Components: Compiler, Grape
> Affects Versions: 2.4.3
> Environment: Essentially independent of the environment, as long as
> Groovy scripts use Grape; also this bug seems to be present since at least
> Groovy 1.7.5.
> Reporter: Jex Jexler
> Assignee: Daniel Sun
> Priority: Minor
> Labels: Compile, Grape, Groovy, Ivy
> Fix For: 5.0.0-alpha-12, 4.0.25, 3.0.24
>
> Attachments: GROOVY-7407-Jenkins-Pipeline.txt, GROOVY-7407-main.zip,
> GrabConcurrencyTest.java, GrapeAndGroovyShellConcurrencyTest.java,
> GroovyCompileConcurrencyTest.java,
> WorkaroundGroovy7407WrappingGrapeEngine.java,
> stacktrace-GrapeAndGroovyShellConcurrencyTest-1.txt,
> stacktrace-GrapeAndGroovyShellConcurrencyTest-2.txt,
> stacktrace-GroovyCompileConcurrencyTest-1.txt,
> stacktrace-GroovyCompileConcurrencyTest-2.txt
>
>
> If Groovy scripts that import the same libraries via Grape are compiled in
> separate threads, compilation may fail due to race conditions.
> This does not happen if several threads use the *same* instance of
> GroovyClassLoader (GCL), because parseClass() uses synchronization.
> But as soon as different GCLs are used in separate threads or if the compiler
> is used directly (CompilationUnit.compile()), the issue occurs and
> compilation can fail.
> Two Java unit tests have be attached, which reproduce the issue, although
> this cannot be guaranteed with 100% certainty, because there is a race
> condition.
> Two different stacktraces have been observed for each unit test (with origins
> in Grape and in Ivy), which have also been attached (plus in a different
> environment (Tomcat webapp CentOS) once a an exception down in Ivy had been
> observed that seemed to be related to unzipping a JAR file, but no precise
> record of that exists any more).
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
