[
https://issues.apache.org/jira/browse/GROOVY-12656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18137385#comment-18137385
]
ASF GitHub Bot commented on GROOVY-12656:
-----------------------------------------
testlens-app[bot] commented on PR #3177:
URL: https://github.com/apache/groovy/pull/3177#issuecomment-6609806054
## 🚨 TestLens detected 1 failed test 🚨
### Test Summary
> [!TIP]
> Inspect all details with the [TestLens
CLI](https://testlens.app/docs/features/cli): `testlens pr 3177`
#### [Build and test / lts \(17, windows-latest,
1\)](https://github.com/apache/groovy/actions/runs/41670915817/job/126038714140?pr=3177)
> :test
| Test | Runs | Flakiness |
|---|---|--:|
| ParallelAnnotationTest > testParallelForRunsConcurrently\(\) | ❌ |
0% 🟢 |
🏷️ Commit: 47a701bd9970d1184f6c30da8846dffa052ddda7
▶️ Tests: 90430 executed
🟡 Checks: 9/24 completed
### Test Failures
<details><summary><strong>ParallelAnnotationTest >
testParallelForRunsConcurrently()</strong> (:test in <a
href="https://github.com/apache/groovy/actions/runs/41670915817/job/126038714140?pr=3177";>Build
and test / lts (17, windows-latest, 1)</a>)</summary>
```
java.lang.reflect.UndeclaredThrowableException
at
java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native
Method)
at
java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
at
java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at
java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)
at
java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:481)
at
java.base/java.util.concurrent.ForkJoinTask.getThrowableException(ForkJoinTask.java:562)
at
java.base/java.util.concurrent.ForkJoinTask.reportException(ForkJoinTask.java:591)
at
java.base/java.util.concurrent.ForkJoinTask.join(ForkJoinTask.java:672)
at
org.codehaus.groovy.runtime.ParallelCollectionExtensions.lambda$eachParallel$1(ParallelCollectionExtensions.java:118)
at
org.codehaus.groovy.runtime.ParallelCollectionExtensions.withPool(ParallelCollectionExtensions.java:405)
at
org.codehaus.groovy.runtime.ParallelCollectionExtensions.eachParallel(ParallelCollectionExtensions.java:117)
at TestScript7$_run_closure1$_closure2.doCall(TestScript7.groovy:20)
at groovy.lang.Closure.invokeHandle(Closure.java:647)
at groovy.lang.Closure.invokeCached(Closure.java:618)
at groovy.lang.Closure.call(Closure.java:584)
at groovy.lang.Closure.call(Closure.java:543)
at
org.codehaus.groovy.runtime.DefaultGroovyMethods.times(DefaultGroovyMethods.java:17402)
at TestScript7$_run_closure1.doCall(TestScript7.groovy:16)
at groovy.lang.Closure.invokeHandle(Closure.java:647)
at groovy.lang.Closure.invokeCached(Closure.java:618)
at groovy.lang.Closure.call(Closure.java:584)
at
org.codehaus.groovy.runtime.ConvertedClosure.invokeCustom(ConvertedClosure.java:55)
at
org.codehaus.groovy.runtime.ConversionHandler.invoke(ConversionHandler.java:130)
at jdk.proxy2/jdk.proxy2.$Proxy55.apply(Unknown Source)
at groovy.concurrent.AsyncScope.lambda$withScope$0(AsyncScope.java:167)
at
org.apache.groovy.runtime.async.ScopedLocal$Carrier.lambda$call$0(ScopedLocal.java:320)
at
org.apache.groovy.runtime.async.ScopedLocal$ThreadLocalImpl.bind(ScopedLocal.java:428)
at
org.apache.groovy.runtime.async.ScopedLocal$Carrier.lambda$execute$1(ScopedLocal.java:338)
at
org.apache.groovy.runtime.async.ScopedLocal$Carrier.execute(ScopedLocal.java:340)
at
org.apache.groovy.runtime.async.ScopedLocal$Carrier.call(ScopedLocal.java:320)
at
org.apache.groovy.runtime.async.ScopedLocal.where(ScopedLocal.java:220)
at
org.apache.groovy.runtime.async.DefaultAsyncScope.withCurrent(DefaultAsyncScope.java:99)
at groovy.concurrent.AsyncScope.withCurrent(AsyncScope.java:121)
at groovy.concurrent.AsyncScope.withScope(AsyncScope.java:167)
at
groovy.concurrent.ParallelScope.lambda$withPool$1(ParallelScope.java:92)
at
org.apache.groovy.runtime.async.ScopedLocal$Carrier.lambda$call$0(ScopedLocal.java:320)
at
org.apache.groovy.runtime.async.ScopedLocal$ThreadLocalImpl.bind(ScopedLocal.java:428)
at
org.apache.groovy.runtime.async.ScopedLocal$Carrier.lambda$execute$1(ScopedLocal.java:338)
at
org.apache.groovy.runtime.async.ScopedLocal$Carrier.execute(ScopedLocal.java:340)
at
org.apache.groovy.runtime.async.ScopedLocal$Carrier.call(ScopedLocal.java:320)
at
org.apache.groovy.runtime.async.ScopedLocal.where(ScopedLocal.java:220)
at
org.apache.groovy.runtime.async.DefaultPool.withCurrent(DefaultPool.java:262)
at groovy.concurrent.Pool.withCurrent(Pool.java:152)
at groovy.concurrent.ParallelScope.withPool(ParallelScope.java:92)
at TestScript7.run(TestScript7.groovy:14)
at groovy.lang.GroovyShell.evaluate(GroovyShell.java:552)
at groovy.lang.GroovyShell.evaluate(GroovyShell.java:587)
at groovy.lang.GroovyShell.evaluate(GroovyShell.java:571)
at groovy.test.GroovyAssert.assertScript(GroovyAssert.java:107)
at groovy.test.GroovyAssert.assertScript(GroovyAssert.java:97)
at
groovy.concurrent.ParallelAnnotationTest.testParallelForRunsConcurrently(ParallelAnnotationTest.groovy:133)
Caused by: java.lang.reflect.UndeclaredThrowableException
at
java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)
at
java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:481)
at
java.base/java.util.concurrent.ForkJoinTask.getThrowableException(ForkJoinTask.java:562)
at
java.base/java.util.concurrent.ForkJoinTask.reportException(ForkJoinTask.java:591)
at
java.base/java.util.concurrent.ForkJoinTask.invoke(ForkJoinTask.java:689)
at
java.base/java.util.stream.ForEachOps$ForEachOp.evaluateParallel(ForEachOps.java:159)
at
java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateParallel(ForEachOps.java:173)
at
java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:233)
at
java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
at
java.base/java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:765)
at
org.codehaus.groovy.runtime.ParallelCollectionExtensions.lambda$eachParallel$0(ParallelCollectionExtensions.java:118)
at
java.base/java.util.concurrent.ForkJoinTask$AdaptedRunnableAction.exec(ForkJoinTask.java:1375)
at
java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373)
at
java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1193)
at
java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1666)
at
java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1633)
at
java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165)
Caused by: java.lang.reflect.UndeclaredThrowableException
at jdk.proxy2/jdk.proxy2.$Proxy54.accept(Unknown Source)
at
java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
at
java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:992)
at
java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
at
java.base/java.util.stream.ForEachOps$ForEachTask.compute(ForEachOps.java:290)
at
java.base/java.util.concurrent.CountedCompleter.exec(CountedCompleter.java:754)
... 5 more
Caused by: java.util.concurrent.TimeoutException
at
java.base/java.util.concurrent.CyclicBarrier.dowait(CyclicBarrier.java:259)
at
java.base/java.util.concurrent.CyclicBarrier.await(CyclicBarrier.java:437)
at
TestScript7$_run_closure1$_closure2$_closure3.doCall(TestScript7.groovy:23)
at groovy.lang.Closure.invokeHandle(Closure.java:647)
at groovy.lang.Closure.invokeCached(Closure.java:618)
at groovy.lang.Closure.call(Closure.java:584)
at
org.codehaus.groovy.runtime.ConvertedClosure.invokeCustom(ConvertedClosure.java:55)
at
org.codehaus.groovy.runtime.ConversionHandler.invoke(ConversionHandler.java:130)
... 11 more
```
</details>
### Rerun Controls
> [!NOTE]
> Checks are currently running using the configuration below.
Select tests to mute in this pull request:
🔲 ParallelAnnotationTest > testParallelForRunsConcurrently\(\) <!
> Closure packing packs a closure literal composed with >> or << whose
> composition escapes
> ----------------------------------------------------------------------------------------
>
> Key: GROOVY-12656
> URL: https://issues.apache.org/jira/browse/GROOVY-12656
> Project: Groovy
> Issue Type: Bug
> Affects Versions: 7.0.0-alpha-1, 6.0.0
> Reporter: Scott Murphy Heiberg
> Priority: Major
>
> {code:groovy}
> class Holder { Closure handler }
> @groovy.transform.PackedClosures
> class C {
> void install(Holder h, Closure c) { h.handler = c >> { x -> x + 1 } }
> Closure make(Closure c) { return { x -> x + 1 } << c }
> }
> def h = new Holder()
> new C().install(h, { x -> x * 2 })
> h.handler.delegate = 'd'
> def r = new C().make({ x -> x * 2 })
> r.delegate = 'd'
> {code}
> *Actual:* both delegate assignments throw
> {{java.lang.UnsupportedOperationException: Cannot set a delegate on a
> @PackedClosures closure (hoisted method '$packed$closure$0') ...}}. The same
> happens with {{-Dgroovy.target.closure.pack=true}} and under {{@TypeChecked}}
> and {{@CompileStatic}}.
> *Expected:* the closure literal is declined from packing, as it is when
> stored or returned directly, and setting a delegate works as it does without
> packing.
> Cause: the compile-time escape walk in
> {{ClosureWriter.collectEscapingClosures}} marks only a literal that is itself
> the stored, appended or returned value. Composition builds a ComposedClosure
> that keeps a clone of the literal (the clone of a packed closure is still
> packed) and passes setDelegate on to it, so the literal escapes along with
> the composition.
> Verified on 6.0.0 and master.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
