paulk-asert commented on PR #3211: URL: https://github.com/apache/groovy/pull/3211#issuecomment-6647425408
LGTM, thanks. I probed this across dynamic/TC/CS. Besides the compile crash and VerifyError, master also silently returned this for def r = ++this (and --this) rather than the next()/previous() result, and the PR fixes that too. Could you widen the test a little: the issue's assert (++this), an assertion on the value of ++this, this++/--this, ++super in a subclass, and a @CompileStatic variant? One aside: ++super dispatches to the subclass's next(), whereas under CS super + 1 calls the parent's plus. That's pre-existing and not something this PR needs to solve. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
