[
https://issues.apache.org/jira/browse/GROOVY-11726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18138804#comment-18138804
]
ASF GitHub Bot commented on GROOVY-11726:
-----------------------------------------
codecov-commenter commented on PR #3228:
URL: https://github.com/apache/groovy/pull/3228#issuecomment-6660051427
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/3228?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
:x: Patch coverage is `70.58824%` with `5 lines` in your changes missing
coverage. Please review.
:white_check_mark: Project coverage is 74.1784%. Comparing base
([`ee802a1`](https://app.codecov.io/gh/apache/groovy/commit/ee802a1814eae7a50016cf6ad2896ff9e80f6665?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
to head
([`f11c5d4`](https://app.codecov.io/gh/apache/groovy/commit/f11c5d40d4929915ac1f188e052f534436053414?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing
lines](https://app.codecov.io/gh/apache/groovy/pull/3228?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Patch % | Lines |
|---|---|---|
|
[src/main/java/groovy/lang/GroovyClassLoader.java](https://app.codecov.io/gh/apache/groovy/pull/3228?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fgroovy%2Flang%2FGroovyClassLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9ncm9vdnkvbGFuZy9Hcm9vdnlDbGFzc0xvYWRlci5qYXZh)
| 70.5882% | [3 Missing and 2 partials :warning:
](https://app.codecov.io/gh/apache/groovy/pull/3228?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/groovy/pull/3228?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #3228 +/- ##
==================================================
+ Coverage 74.1723% 74.1784% +0.0061%
- Complexity 43760 43766 +6
==================================================
Files 1692 1692
Lines 149599 149611 +12
Branches 28386 28390 +4
==================================================
+ Hits 110961 110979 +18
+ Misses 28430 28428 -2
+ Partials 10208 10204 -4
```
| [Files with missing
lines](https://app.codecov.io/gh/apache/groovy/pull/3228?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Coverage Δ | |
|---|---|---|
|
[src/main/java/groovy/lang/GroovyClassLoader.java](https://app.codecov.io/gh/apache/groovy/pull/3228?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fgroovy%2Flang%2FGroovyClassLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9ncm9vdnkvbGFuZy9Hcm9vdnlDbGFzc0xvYWRlci5qYXZh)
| `73.3010% <70.5882%> (-0.4490%)` | :arrow_down: |
... and [12 files with indirect coverage
changes](https://app.codecov.io/gh/apache/groovy/pull/3228/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests,
report on failures, and find test suite problems.
- :package: [JS Bundle
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save
yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
> Performance Regression in GroovyClassLoader.parseClass After Migration to
> Groovy 4
> ----------------------------------------------------------------------------------
>
> Key: GROOVY-11726
> URL: https://issues.apache.org/jira/browse/GROOVY-11726
> Project: Groovy
> Issue Type: Bug
> Reporter: Puneet Singla
> Priority: Critical
> Labels: performance
>
> After upgrading to Groovy 4, we have observed a *significant increase in
> compilation time* when using the following method from {{GroovyClassLoader}}:
> {code:java}
> public Class parseClass(final GroovyCodeSource codeSource, boolean
> shouldCacheSource) throws CompilationFailedException
> {code}
> This function was previously performing optimally in Groovy 3.0.13, but with
> Groovy 4.0.24, compilation latency has *increased significantly.* Earlier it
> used to take about 4 minutes to compile a bunch of scripts but now it is
> taking about 9 minutes for the same scripts.
> ----
> *Steps to Reproduce:*
> # Use {{GroovyClassLoader}} to compile Groovy scripts at runtime using the
> {{parseClass(GroovyCodeSource, boolean)}} method.
> # Benchmark the time taken before and after the migration to Groovy 4.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
