[jira] [Commented] (GROOVY-12714) `@CompileStatic` PECS wildcard containment diverges from javac (JLS 4.5.1)

[ASF GitHub Bot (Jira) via notifications]

    [ 
https://issues.apache.org/jira/browse/GROOVY-12714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18139861#comment-18139861
 ] 

ASF GitHub Bot commented on GROOVY-12714:
-----------------------------------------

testlens-app[bot] commented on PR #3246:
URL: https://github.com/apache/groovy/pull/3246#issuecomment-6693818904

   ## 🚨 TestLens detected 2 failed tests 🚨
   
   ### Test Summary
   > [!TIP]
   > Inspect all details with the [TestLens 
CLI](https://testlens.app/docs/features/cli): `testlens pr 3246`
   
   #### [Build and test / lts \(17, 
macos-latest\)](https://github.com/apache/groovy/actions/runs/42268758873/job/128102928069?pr=3246)
 > :test
   
   | Test | Runs | Flakiness |
   |---|---|--:|
   | ParserNegativeSyntaxTest > closed paren groups before a later syntax error 
are not missing parens\(\) | 🚫 ❌ | 0% 🟢 |
   | ParserNegativeSyntaxTest > type pattern in case label after a record 
declaration\(\) | 🚫 ❌ | 0% 🟢 |
   
   🏷️ Commit: 18f8622a1e9e0af6988c508001ccfebc10646575
   ▶️ Tests:  66977 executed
   🟡 Checks: 8/24 completed
   
   ### Test Failures
   
   <details><summary><strong>ParserNegativeSyntaxTest > closed paren groups 
before a later syntax error are not missing parens()</strong> (:test in <a 
href="https://github.com/apache/groovy/actions/runs/42268758873/job/128102928069?pr=3246";>Build
 and test / lts (17, macos-latest)</a>)</summary>
   
   ```
   org.opentest4j.AssertionFailedError: expected parse to fail
        at org.junit.jupiter.api.Assertions.fail(Assertions.java:142)
        at 
org.apache.groovy.parser.antlr4.TestUtils.compileMessage(TestUtils.groovy:130)
        at 
org.apache.groovy.parser.antlr4.TestUtils.expectParseError(TestUtils.groovy:190)
        at org.apache.groovy.parser.antlr4.ParserNegativeSyntaxTest.closed 
paren groups before a later syntax error are not missing 
parens(ParserNegativeSyntaxTest.groovy:3945)
   ```
   
   </details>
   <details><summary><strong>ParserNegativeSyntaxTest > type pattern in case 
label after a record declaration()</strong> (:test in <a 
href="https://github.com/apache/groovy/actions/runs/42268758873/job/128102928069?pr=3246";>Build
 and test / lts (17, macos-latest)</a>)</summary>
   
   ```
   org.opentest4j.AssertionFailedError: expected parse to fail
        at org.junit.jupiter.api.Assertions.fail(Assertions.java:142)
        at 
org.apache.groovy.parser.antlr4.TestUtils.compileMessage(TestUtils.groovy:130)
        at 
org.apache.groovy.parser.antlr4.TestUtils.expectParseError(TestUtils.groovy:190)
        at org.apache.groovy.parser.antlr4.ParserNegativeSyntaxTest.type 
pattern in case label after a record 
declaration(ParserNegativeSyntaxTest.groovy:3927)
   ```
   
   </details>
   
   ### Rerun Controls
   > [!NOTE]
   > Checks are currently running using the configuration below.
   
   Select tests to mute in this pull request:
   
   🔲 ParserNegativeSyntaxTest > closed paren groups before a later syntax error 
are not missing parens\(\) <!

> `@CompileStatic` PECS wildcard containment diverges from javac (JLS 4.5.1)
> --------------------------------------------------------------------------
>
>                 Key: GROOVY-12714
>                 URL: https://issues.apache.org/jira/browse/GROOVY-12714
>             Project: Groovy
>          Issue Type: Bug
>          Components: Static Type Checker
>            Reporter: Daniel Sun
>            Priority: Major
>
> h2. Problem
> Under {{@CompileStatic}}, Groovy's generics / wildcard containment was more 
> permissive than javac for several JLS 4.5.1 PECS cases, including:
> * adding a non-subtype into {{List<? super Integer>}} (e.g. {{add(Double)}})
> * treating {{? extends Number}} as contained in {{? extends Integer}} (and 
> the dual lower-bound mistake)
> * assigning a wildcard producer {{List<? extends Number>}} to an invariant 
> {{List<Number>}}
> h2. Fix
> Align containment and capture write checks with JLS SE 25 §§4.5.1, 4.5.2, 
> 4.10.2, 5.1.10 so {{@CompileStatic}} matches javac.
> h2. Tests
> Extend {{gls.generics.GenericsJavaCompatibilityTest}} with PECS containment / 
> transfer / negative cases that both compilers must agree on.
> h2. PR
> https://github.com/apache/groovy/pull/3246



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)